Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.h - Issue 1188203002: Implementation of setSinkId() for HTMLMediaElement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.h

Issue 1188203002: Implementation of setSinkId() for HTMLMediaElement. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix missing #include and broken previous upload Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/media/audio_output_devices/audio_output_devices-setsinkid.html ('k') | Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.cpp » ('j') | Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.h

diff --git a/Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.h b/Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.h

index f75cedd438c24f3b923734d57dcc7e17f68e5abd..bfccfe1946614c92aa05ebe9ae21d42ef0c98d4d 100644

--- a/Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.h

+++ b/Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.h

@@ -22,7 +22,8 @@ class HTMLMediaElementAudioOutputDevice final : public NoBaseWillBeGarbageCollec

public:

DECLARE_VIRTUAL_TRACE();

static String sinkId(HTMLMediaElement&);

- static ScriptPromise setSinkId(ScriptState*, HTMLMediaElement&, const String& newSinkId);

Mike West 2015/06/17 11:44:37 We generally keep the parameter name for generic t

Guido Urdaneta 2015/06/17 12:25:15 Done.

+ static ScriptPromise setSinkId(ScriptState*, HTMLMediaElement&, const String&);

+ friend class SetSinkIdCallbacks;

Mike West 2015/06/17 11:44:37 This is just for `from(HTMLMediaElement)`, right?

Guido Urdaneta 2015/06/17 12:25:15 Done.

private:

HTMLMediaElementAudioOutputDevice();