Chromium Code Reviews Chromium Code Reviews
Issue 1188203002:
Implementation of setSinkId() for HTMLMediaElement. (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| Index: LayoutTests/media/audio_output_devices/audio_output_devices-setsinkid.html |
| diff --git a/LayoutTests/media/audio_output_devices/audio_output_devices-setsinkid.html b/LayoutTests/media/audio_output_devices/audio_output_devices-setsinkid.html |
| index 727b7e42176c7497630d496de089140f2d665601..054c4d81180424fc6691c1c7f5af0739da1480ca 100644 |
| --- a/LayoutTests/media/audio_output_devices/audio_output_devices-setsinkid.html |
| +++ b/LayoutTests/media/audio_output_devices/audio_output_devices-setsinkid.html |
| @@ -6,25 +6,28 @@ |
| <script src="../../resources/testharnessreport.js"></script> |
| </head> |
| <body> |
| - <video id="testVideo"></video> |
| + <audio id="testAudio"></audio> |
| <script> |
| // Tests that the setSinkId() Promise rejects with a NotSupportedError, |
| // because the functionality has not been implemented yet. |
| promise_test(function() { |
| - var video = document.getElementById('testVideo'); |
| - assert_not_equals(video, null); |
| + var audio = document.getElementById('testAudio'); |
| + assert_not_equals(audio, null); |
| - assert_idl_attribute(video, 'setSinkId'); |
| - assert_equals(typeof video.setSinkId, 'function'); |
| - assert_idl_attribute(video, 'sinkId'); |
| - assert_equals(video.sinkId, ''); |
| + assert_idl_attribute(audio, 'setSinkId'); |
| + assert_equals(typeof audio.setSinkId, 'function'); |
| + assert_idl_attribute(audio, 'sinkId'); |
| + assert_equals(audio.sinkId, ''); |
| - return video.setSinkId('').then(function() { |
| - assert_unreached('setSinkId() should not be implemented yet!'); |
| + return audio.setSinkId('').then(function() { |
| + return audio.setSinkId('xxx'); |
| + }, function(error) { |
| + assert_unreached('setSinkId() should have succeeded!'); |
|
Mike West
2015/06/18 06:30:49
Can you also assert that the sink ID has the corre
|
| + }). then(function() { |
| + assert_unreached('setSinkId() should have failed!'); |
| }, function(error) { |
| - assert_equals(error.name, 'NotSupportedError'); |
| return Promise.resolve(); |
| - }); |
| + }) |
| }, 'setSinkId() test'); |
| </script> |
| </body> |
