Implementation of setSinkId() for HTMLMediaElement.

Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.h"
 
 #include "bindings/core/v8/ScriptPromiseResolver.h"
 #include "bindings/core/v8/ScriptState.h"
 #include "core/dom/ExecutionContext.h"
+#include "modules/audio_output_devices/SetSinkIdCallbacks.h"
 #include "platform/Logging.h"
 
 namespace blink {
 
 HTMLMediaElementAudioOutputDevice::HTMLMediaElementAudioOutputDevice()
     : m_sinkId("")
 {
 }
 
 String HTMLMediaElementAudioOutputDevice::sinkId(HTMLMediaElement& element)
 {
     WTF_LOG(Media, __FUNCTION__);
     HTMLMediaElementAudioOutputDevice& aodElement = HTMLMediaElementAudioOutputDevice::from(element);
     return aodElement.m_sinkId;
 }
 
-ScriptPromise HTMLMediaElementAudioOutputDevice::setSinkId(ScriptState* scriptState, HTMLMediaElement& element, const String& newSinkId)
+ScriptPromise HTMLMediaElementAudioOutputDevice::setSinkId(ScriptState* scriptState, HTMLMediaElement& element, const String& sinkId)
 {
     WTF_LOG(Media, __FUNCTION__);
-    return ScriptPromise::rejectWithDOMException(scriptState, DOMException::create(NotSupportedError, "Operation not supported"));
+    WebMediaPlayer* webMediaPlayer = element.webMediaPlayer();
+    if (!webMediaPlayer)
+        return ScriptPromise::rejectWithDOMException(scriptState, DOMException::create(AbortError, "No media player available"));
+
+    // According to spec, "id-multimedia" is equivalent to ""
+    String newSinkId = (sinkId == "id-multimedia") ? "" : sinkId;

[Mike West, 2015/06/17 11:44:37]

The spec isn't terribly clear here.
https://w3c.github.io/mediacapture-output/#idl-def-MediaDeviceId.id-multimedia
defines an enum that isn't used anywhere else in the spec. I'd suggest that
https://w3c.github.io/mediacapture-output/#widl-HTMLMediaElement-setSinkId-Pr...
should make this behavior explicit.

[Guido Urdaneta, 2015/06/17 12:25:15]

You are right. I just removed support for id-multimedia.
We can re-add it later, when the spec becomes clearer.

+    RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
+    ScriptPromise promise = resolver->promise();

[Mike West, 2015/06/17 11:44:37]

Nit: Could you just return `resolver->promise()` rather than creating the temp
variable?

[Guido Urdaneta, 2015/06/17 12:25:15]

Done.

+    HTMLMediaElementAudioOutputDevice& aodElement = HTMLMediaElementAudioOutputDevice::from(element);
+    if (newSinkId == aodElement.m_sinkId)
+        resolver->resolve();
+    else
+        webMediaPlayer->setSinkId(newSinkId, new SetSinkIdCallbacks(resolver, element, newSinkId));
+
+    return promise;
 }
 
 const char* HTMLMediaElementAudioOutputDevice::supplementName()
 {
     return "HTMLMediaElementAudioOutputDevice";
 }
 
 HTMLMediaElementAudioOutputDevice& HTMLMediaElementAudioOutputDevice::from(HTMLMediaElement& element)
 {
     HTMLMediaElementAudioOutputDevice* supplement = static_cast<HTMLMediaElementAudioOutputDevice*>(WillBeHeapSupplement<HTMLMediaElement>::from(element, supplementName()));
     if (!supplement) {
         supplement = new HTMLMediaElementAudioOutputDevice();
         provideTo(element, supplementName(), adoptPtrWillBeNoop(supplement));
     }
     return *supplement;
 }
 
 DEFINE_TRACE(HTMLMediaElementAudioOutputDevice)
 {
     WillBeHeapSupplement<HTMLMediaElement>::trace(visitor);
 }
 
 } // namespace blink