Move "oauth2" manifest key parsing out of Extension class.

chrome/common/extensions/api/identity/oauth2_manifest_handler.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_COMMON_EXTENSIONS_API_IDENTITY_OAUTH2_MANIFEST_HANDLER_H_
+#define CHROME_COMMON_EXTENSIONS_API_IDENTITY_OAUTH2_MANIFEST_HANDLER_H_
+
+#include <set>
+#include <string>
+#include <vector>
+
+#include "chrome/common/extensions/extension.h"
+#include "chrome/common/extensions/manifest_handler.h"
+
+namespace extensions {
+
+// OAuth2 info included in the extension.
+struct OAuth2Info : public Extension::ManifestData {
+  OAuth2Info();
+  ~OAuth2Info();
+
+  std::string client_id;
+  std::vector<std::string> scopes;
+  static const OAuth2Info* GetOAuth2Info(const Extension* extension);

[Devlin, 2013/01/14 20:18:34]

You should comment that this is never NULL.

It also makes me nervous that we crash if we try to access the OAuth2Info before
we parse the key (this wasn't a problem before, because we had an OAuth2 object,
not a pointer). I don't think it will be a problem currently, but if we keep
this somewhat-risky behavior, you should comment that trying to access it before
the key is parsed will result in a crash.

[Yoyo Zhou, 2013/01/15 01:59:56]

If it's never NULL, it's better to return a const reference than a pointer.

[SanjoyPal, 2013/01/16 19:10:52]

Done.

[SanjoyPal, 2013/01/16 19:10:52]

Done.

+};
+
+// Parses the "oauth2" manifest key.
+class OAuth2ManifestHandler : public ManifestHandler {
+ public:
+  OAuth2ManifestHandler();
+  virtual ~OAuth2ManifestHandler();
+
+  virtual bool Parse(const base::Value* value, Extension* extension,
+                     string16* error) OVERRIDE;
+  virtual bool HasNoKey(Extension* extension, string16* error) OVERRIDE;
+};
+
+}  // namespace extensions
+
+#endif  // CHROME_COMMON_EXTENSIONS_API_IDENTITY_OAUTH2_MANIFEST_HANDLER_H_