Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 11882002: Fix some scan_sources.py dependencies (Closed)

Created:
7 years, 11 months ago by elijahtaylor1
Modified:
7 years, 11 months ago
Reviewers:
noelallen1, binji
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Fix some scan_sources.py dependencies Search for include files relative to the directory of the file that included them. BUG=169539 TEST=manual, run gyp from chrome and verify includes are found Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=10614

Patch Set 1 #

Patch Set 2 : merge with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M build/scan_sources.py View 3 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
elijahtaylor1
7 years, 11 months ago (2013-01-11 20:58:39 UTC) #1
Roland McGrath
Technically, the directory containing the source file will only be searched for #include "..." syntax, ...
7 years, 11 months ago (2013-01-11 21:03:25 UTC) #2
elijahtaylor1
I can add a comment if desired, but seeing as this script has always erred ...
7 years, 11 months ago (2013-01-11 21:19:52 UTC) #3
elijahtaylor1
ping On 2013/01/11 21:19:52, elijahtaylor1 wrote: > I can add a comment if desired, but ...
7 years, 11 months ago (2013-01-14 19:02:37 UTC) #4
binji
lgt.m but you should probably get Noel to review.
7 years, 11 months ago (2013-01-14 19:12:05 UTC) #5
noelallen1
lgtm
7 years, 11 months ago (2013-01-16 01:08:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/elijahtaylor@chromium.org/11882002/1
7 years, 11 months ago (2013-01-16 19:46:38 UTC) #7
commit-bot: I haz the power
7 years, 11 months ago (2013-01-16 19:46:40 UTC) #8
Presubmit check for 11882002-1 failed and returned exit status 1.

Running presubmit commit checks ...
Error processing /b/commit-queue/workdir/nacl/build/scan_sources.py:
  Cannot execute command ['pychecker', '-stdlib']. failed reason: [Errno 2] No
such file or directory 

** Presubmit Warnings **
License must match:
.*? Copyright (\(c\) )?(2013|2012|2011|2010|2009|2008|2007|2006|2006-2008) The
Native Client Authors\. All rights reserved\.\n.*? Use of this source code is
governed by a BSD-style license that can be\n.*? found in the LICENSE file\.(?:
\*/)?\n
Found a bad license header in these files:
  build/scan_sources.py

Powered by Google App Engine
This is Rietveld 408576698