Issue 1188173003: have build/test scripts automatically update baselines

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1188173003: have build/test scripts automatically update baselines (Closed)

Created:
5 years, 6 months ago by Jennifer Messerly

Modified:
5 years, 6 months ago

Reviewers:
Leaf, vsm

CC:
dev-compiler+reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

have build/test scripts automatically update baselines we already have to review them, so running a diff and failing the rest of the test pass seems unhelpful. Instead operate like our generated SDK does, and update in place R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/5733c0bab6e6183458a1ad5ae341b16b72c2195d

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -58 lines)			Patch
M	.gitignore	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	test/codegen_test.dart	View	13 chunks	+17 lines, -17 lines	0 comments	Download
M	tool/build_sdk.sh	View	1 chunk	+1 line, -13 lines	0 comments	Download
M	tool/test.sh	View	2 chunks	+0 lines, -24 lines	0 comments	Download

Total messages: 5 (1 generated)

Jennifer Messerly

I think the old workflow makes more sense in pre-git days. With git it's super ...

5 years, 6 months ago (2015-06-16 23:50:12 UTC) #3

Jennifer Messerly

5 years, 6 months ago (2015-06-17 16:06:03 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5733c0bab6e6183458a1ad5ae341b16b72c2195d (presubmit successful).