Issue 1188163004: Improve widgets/README.md based on Hixie's feeback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1188163004: Improve widgets/README.md based on Hixie's feeback (Closed)

Created:
5 years, 6 months ago by abarth-chromium

Modified:
5 years, 6 months ago

Reviewers:
Hixie

CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Improve widgets/README.md based on Hixie's feeback R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/be11a0b9540dcac6019db7601d38bbe18e2e2ddd

Patch Set 1 #

Total comments: 2

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -24 lines)			Patch
	M	sky/sdk/lib/widgets/README.md	View		5 chunks	+25 lines, -24 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Hixie

lgtm https://codereview.chromium.org/1188163004/diff/1/sky/sdk/lib/widgets/README.md File sky/sdk/lib/widgets/README.md (right): https://codereview.chromium.org/1188163004/diff/1/sky/sdk/lib/widgets/README.md#newcode74 sky/sdk/lib/widgets/README.md:74: decoration: const BoxDecoration( decoration should go first, since ...

5 years, 6 months ago (2015-06-17 17:13:16 UTC) #2

abarth-chromium

https://codereview.chromium.org/1188163004/diff/1/sky/sdk/lib/widgets/README.md File sky/sdk/lib/widgets/README.md (right): https://codereview.chromium.org/1188163004/diff/1/sky/sdk/lib/widgets/README.md#newcode74 sky/sdk/lib/widgets/README.md:74: decoration: const BoxDecoration( On 2015/06/17 at 17:13:16, Hixie wrote: ...

5 years, 6 months ago (2015-06-17 17:39:29 UTC) #3

abarth-chromium

5 years, 6 months ago (2015-06-17 17:39:52 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
be11a0b9540dcac6019db7601d38bbe18e2e2ddd (presubmit successful).

Expand Messages | Collapse Messages