Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(980)

Unified Diff: chrome/browser/ui/webui/devtools_ui.cc

Issue 11881055: Simplify WebUI data sources. Currently WebUI data sources implement a URLDataSourceDelegate interfa… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix issue in about_ui exposed by cros tests Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/devtools_ui.cc
===================================================================
--- chrome/browser/ui/webui/devtools_ui.cc (revision 176942)
+++ chrome/browser/ui/webui/devtools_ui.cc (working copy)
@@ -11,13 +11,12 @@
#include "base/string_util.h"
#include "chrome/browser/net/chrome_url_request_context.h"
#include "chrome/browser/profiles/profile.h"
-#include "chrome/browser/ui/webui/chrome_url_data_manager.h"
#include "chrome/common/url_constants.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/devtools_client_host.h"
#include "content/public/browser/devtools_http_handler.h"
#include "content/public/browser/render_view_host.h"
-#include "content/public/browser/url_data_source_delegate.h"
+#include "content/public/browser/url_data_source.h"
#include "content/public/browser/web_contents.h"
#include "content/public/browser/web_ui.h"
#include "ui/base/resource/resource_bundle.h"
@@ -34,15 +33,16 @@
} // namespace
-class DevToolsDataSource : public content::URLDataSourceDelegate {
+class DevToolsDataSource : public content::URLDataSource {
public:
DevToolsDataSource();
- // content::URLDataSourceDelegate implementation.
+ // content::URLDataSource implementation.
virtual std::string GetSource() OVERRIDE;
- virtual void StartDataRequest(const std::string& path,
- bool is_incognito,
- int request_id) OVERRIDE;
+ virtual void StartDataRequest(
+ const std::string& path,
+ bool is_incognito,
+ const content::URLDataSource::GotDataCallback& callback) OVERRIDE;
virtual std::string GetMimeType(const std::string& path) const OVERRIDE;
private:
@@ -58,12 +58,12 @@
return chrome::kChromeUIDevToolsHost;
}
-void DevToolsDataSource::StartDataRequest(const std::string& path,
- bool is_incognito,
- int request_id) {
+void DevToolsDataSource::StartDataRequest(
+ const std::string& path,
+ bool is_incognito,
+ const content::URLDataSource::GotDataCallback& callback) {
std::string filename = PathWithoutParams(path);
-
int resource_id =
content::DevToolsHttpHandler::GetFrontendResourceId(filename);
@@ -73,7 +73,7 @@
const ResourceBundle& rb = ResourceBundle::GetSharedInstance();
scoped_refptr<base::RefCountedStaticMemory> bytes(rb.LoadDataResourceBytes(
resource_id));
- url_data_source()->SendResponse(request_id, bytes);
+ callback.Run(bytes);
}
std::string DevToolsDataSource::GetMimeType(const std::string& path) const {

Powered by Google App Engine
This is Rietveld 408576698