Telemetry: add a metadata layer between page set and .wpr.

tools/telemetry/telemetry/record_wpr.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 import logging
+import os
+import shutil
 import sys
+import tempfile
 import time
 
 from telemetry import all_page_actions # pylint: disable=W0611
 from telemetry import browser_finder
 from telemetry import browser_options
 from telemetry import discover
 from telemetry import multi_page_benchmark
 from telemetry import page_runner
 from telemetry import page_set
 from telemetry import page_test
@@ skipping 53 matching lines @@
   recorder.AddCommandLineOptions(parser)
 
   _, args = parser.parse_args()
 
   if len(args) != 1:
     parser.print_usage()
     sys.exit(1)
 
   ps = page_set.PageSet.FromFile(args[0])
 
+  # Set the archive path to something temporary.
+  temp_target_wpr_file_path = tempfile.mkstemp()[1]
+  for page in ps.pages:
+    page.archive_path = temp_target_wpr_file_path
+
+  # Do the actual recording.
   options.wpr_mode = wpr_modes.WPR_RECORD
   recorder.CustomizeBrowserOptions(options)
   possible_browser = browser_finder.FindBrowser(options)
   if not possible_browser:
     print >> sys.stderr, """No browser found.\n
 Use --browser=list to figure out which are available.\n"""
     sys.exit(1)
   results = page_test.PageTestResults()
+  pages_run = []
   with page_runner.PageRunner(ps) as runner:
-    runner.Run(options, possible_browser, recorder, results)
+    runner.Run(options, possible_browser, recorder, results, pages_run)
 
-  if len(results.page_failures):
+  if results.page_failures:
     logging.warning('Failed pages: %s', '\n'.join(
         [failure['page'].url for failure in results.page_failures]))
 
-  if len(results.skipped_pages):
+  if results.skipped_pages:
     logging.warning('Skipped pages: %s', '\n'.join(
         [skipped['page'].url for skipped in results.skipped_pages]))
+
+  if not results.page_failures:
+    # Update the metadata for the pages which were recorded.
+    target_wpr_file_path = ps.wpr_archive_info.AddNewRecording(pages_run)

[dtu, 2013/01/30 02:19:10]

This method could take temp_target_wpr_file_path and do all of the below
implicitly. Then your PSArchiveInfo object would always be consistent with the
filesystem (from this point of view, assuming no errors).

[marja, 2013/01/30 12:26:22]

Done.

+
+    shutil.move(temp_target_wpr_file_path, target_wpr_file_path)
+    ps.wpr_archive_info.WriteToFile()
+    ps.wpr_archive_info.DeleteAbandonedWprFiles()
+
+  else:
+    os.remove(temp_target_wpr_file_path)
+
   return min(255, len(results.page_failures))