Issue 11881048: Change debug stub log message verbosity level to 1.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11881048: Change debug stub log message verbosity level to 1. (Closed)

Created:
7 years, 11 months ago by halyavin

Modified:
7 years, 11 months ago

Reviewers:
Mark Seaborn

CC:
native-client-reviews_googlegroups.com, Nikolay

Base URL:
svn://svn.chromium.org/native_client/trunk/src/native_client/

Visibility:
Public.

More Reviews

Description

Debug stub: Change log message verbosity level to 1 Currently there is no way to disable debug stub log messages. Changing their verbosity level to positive value makes this possible. Chrome side of the change is here: https://codereview.chromium.org/11875038/ BUG= none TEST= gdb_tests, run_debug_stub_test Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=10609

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -4 lines)			Patch
M	src/trusted/debug_stub/session.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/debug_stub/nacl.scons	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/gdb/nacl.scons	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark Seaborn

LGTM https://codereview.chromium.org/11881048/diff/1/tests/gdb/gdb_test.py File tests/gdb/gdb_test.py (right): https://codereview.chromium.org/11881048/diff/1/tests/gdb/gdb_test.py#newcode182 tests/gdb/gdb_test.py:182: print options.gdb I don't think you meant to ...

7 years, 11 months ago (2013-01-15 17:13:20 UTC) #2

halyavin

7 years, 11 months ago (2013-01-15 18:32:42 UTC) #3

https://codereview.chromium.org/11881048/diff/1/tests/gdb/gdb_test.py
File tests/gdb/gdb_test.py (right):

https://codereview.chromium.org/11881048/diff/1/tests/gdb/gdb_test.py#newcode182
tests/gdb/gdb_test.py:182: print options.gdb
On 2013/01/15 17:13:20, Mark Seaborn wrote:
> I don't think you meant to leave this here.  Please remove.

Done. I forgot to clear working copy before making changes.

Expand Messages | Collapse Messages