Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 11881046: Merge 139038 (Closed)

Created:
7 years, 11 months ago by tkent
Modified:
7 years, 11 months ago
Reviewers:
tkent
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1364/
Visibility:
Public.

Description

Merge 139038 > REGRESSION(r137406): Text inside an empty optgroup prevents subsequent options from appearing > https://bugs.webkit.org/show_bug.cgi?id=106298 > > Reviewed by Ryosuke Niwa. > > Source/WebCore: > > Test: fast/forms/select/select-empty-optgroup.html > > * html/HTMLSelectElement.cpp: > (WebCore::HTMLSelectElement::recalcListItems): > Traverse to the first element within the 'current' only if it exists. > > LayoutTests: > > * fast/forms/select/select-empty-optgroup-expected.html: Added. > * fast/forms/select/select-empty-optgroup.html: Added. > TBR=tkent@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139721

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
A + LayoutTests/fast/forms/select/select-empty-optgroup.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/forms/select/select-empty-optgroup-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/html/HTMLSelectElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
tkent
7 years, 11 months ago (2013-01-15 07:53:25 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698