Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Unified Diff: ppapi/native_client/tests/ppapi_browser/bad/ppapi_bad.html

Issue 11881038: Refine PNaCl pexe fetch UMA errors to know if the user aborted, etc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sort Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/native_client/tests/ppapi_browser/bad/ppapi_bad.html
diff --git a/ppapi/native_client/tests/ppapi_browser/bad/ppapi_bad.html b/ppapi/native_client/tests/ppapi_browser/bad/ppapi_bad.html
index a76d4e234996813c4d7e5af15aa5678a2557a72e..a26c12dd0b5ebf5994d2e266ec3194fb665acca5 100644
--- a/ppapi/native_client/tests/ppapi_browser/bad/ppapi_bad.html
+++ b/ppapi/native_client/tests/ppapi_browser/bad/ppapi_bad.html
@@ -21,12 +21,12 @@
//<![CDATA[
// PNaCl may have slightly different error messages (pexe instead of nexe).
-function couldNotLoadNexe(is_pnacl, expected_pp_error) {
+function couldNotLoadNexe(is_pnacl, pnacl_refinement) {
if (!is_pnacl) {
return 'NaCl module load failed: could not load nexe url.';
} else {
- return 'NaCl module load failed: PnaclCoordinator: pexe load failed ' +
- '(pp_error=' + expected_pp_error + ').';
+ return 'NaCl module load failed: PnaclCoordinator: pexe load failed' +
+ pnacl_refinement;
}
}
@@ -46,7 +46,7 @@ function declareTests(tester) {
tester,
'cross_origin',
'ppapi_bad_crossorigin.nmf',
- couldNotLoadNexe(is_pnacl, -7 /* PP_ERROR_NOACCESS */));
+ couldNotLoadNexe(is_pnacl, '. No access.'));
// 'cross_manifest' tries to load a cross-origin manifest.
badLoadTest(
@@ -61,7 +61,7 @@ function declareTests(tester) {
tester,
'nonexistent_nexe',
'ppapi_bad_doesnotexist.nmf',
- couldNotLoadNexe(is_pnacl, -2 /* PP_ERROR_FAILED */));
+ couldNotLoadNexe(is_pnacl, ' (pp_error=-2).' /* PP_ERROR_FAILED */));
// 'nonexistent_nexe_only' loads a manifest, then tries to load a nonexistent
// nexe, given only a nexe to choose from.

Powered by Google App Engine
This is Rietveld 408576698