Refine PNaCl pexe fetch UMA errors to know if the user aborted, etc.

ppapi/native_client/src/trusted/plugin/plugin_error.h

 /*
  * Copyright (c) 2011 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 /*
  * Error codes and data structures used to report errors when loading a nexe.
  */
 
@@ skipping 66 matching lines @@
   ERROR_PNACL_CACHE_FILEOPEN_OTHER = 49,
   ERROR_PNACL_CACHE_FETCH_NOACCESS = 50,
   ERROR_PNACL_CACHE_FETCH_NOTFOUND = 51,
   ERROR_PNACL_CACHE_FETCH_OTHER = 52,
   ERROR_PNACL_CACHE_FINALIZE_COPY_NOQUOTA = 53,
   ERROR_PNACL_CACHE_FINALIZE_COPY_NOSPACE = 54,
   ERROR_PNACL_CACHE_FINALIZE_COPY_OTHER = 55,
   ERROR_PNACL_CACHE_FINALIZE_RENAME_NOACCESS = 56,
   ERROR_PNACL_CACHE_FINALIZE_RENAME_OTHER = 57,
   ERROR_PNACL_RESOURCE_FETCH = 58,
-  ERROR_PNACL_PEXE_FETCH = 59,
-  ERROR_PNACL_THREAD_CREATE = 60,
-  ERROR_PNACL_LLC_SETUP = 61,
-  ERROR_PNACL_LD_SETUP = 62,
-  ERROR_PNACL_LLC_INTERNAL = 63,
-  ERROR_PNACL_LD_INTERNAL = 64,
-  ERROR_PNACL_CREATE_TEMP = 65,
+  ERROR_PNACL_PEXE_FETCH_ABORTED = 59,

[Nick Bray (chromium), 2013/01/15 23:12:49]

Only renumber if you're fine with this data being poisoned.  I realize you don't
have any samples, so the point is probably moot, but you should note your
reasoning in the commit message.

[jvoung (off chromium), 2013/01/16 01:31:24]

Done.

+  ERROR_PNACL_PEXE_FETCH_NOACCESS = 60,
+  ERROR_PNACL_PEXE_FETCH_OTHER = 61,
+  ERROR_PNACL_THREAD_CREATE = 62,
+  ERROR_PNACL_LLC_SETUP = 63,
+  ERROR_PNACL_LD_SETUP = 64,
+  ERROR_PNACL_LLC_INTERNAL = 65,
+  ERROR_PNACL_LD_INTERNAL = 66,
+  ERROR_PNACL_CREATE_TEMP = 67,
   // Remove this next code when pnacl is no longer behind a flag (when we
   // remove the --enable-pnacl flag).
-  ERROR_PNACL_NOT_ENABLED = 66,
+  ERROR_PNACL_NOT_ENABLED = 68,
   // If you add a code, read the enum comment above on how to update histograms.
   ERROR_MAX
 };
 
+// Refinements for ERROR_PNACL_LLC_INTERNAL.
+enum PNaClLLCErrorCode {
+  ERROR_PNACL_LLC_STREAM_INIT = 1,

[Nick Bray (chromium), 2013/01/15 23:12:49]

It's unclear to me if these enums belong here (or if they don't, just raising a
question).  Would they work better in the coordinator?

Also, if they aren't used, take them out of the CL.

In any case you should stick the scary "reported to UMA" comments on these. 
Throwing in a "SUCCESS = 0" might also be useful.

[jvoung (off chromium), 2013/01/16 01:31:24]

Perhaps they can be moved to a pnacl specific file, and perhaps the helper
functions for pnacl in the other CL could be moved to the new file also.
They're not used yet, since we still need to figure out how to propagate these
errors.  In fact, I don't think the linker returns anything right now.

I'll remove this and add them in a later CL.  Just wanted some comments on how
to do this, since leaving it with the plugin-specific error code namespace would
mean shifting things again, once we do implement these.

+  ERROR_PNACL_LLC_OOM = 2,
+  ERROR_PNACL_LLC_BITCODE_ABI = 3,
+  ERROR_PNACL_LLC_UNKNOWN = 4,
+  ERROR_PNACL_LLC_MAX
+};
+
+// Refinements for ERROR_PNACL_LD_INTERNAL.
+enum PNaClLDErrorCode {
+  ERROR_PNACL_LD_UNDEFINED_SYMBOLS = 1,
+  ERROR_PNACL_LD_OOM = 2,
+  ERROR_PNACL_LD_UNKNOWN = 3,
+  ERROR_PNACL_LD_MAX
+};
+
 class ErrorInfo {
  public:
   ErrorInfo() {
     Reset();
   }
 
   void Reset() {
     SetReport(ERROR_UNKNOWN, "");
   }
 
@@ skipping 16 matching lines @@
 
  private:
   PluginErrorCode error_code_;
   std::string message_;
   NACL_DISALLOW_COPY_AND_ASSIGN(ErrorInfo);
 };
 
 }  // namespace plugin
 
 #endif  // NATIVE_CLIENT_SRC_TRUSTED_PLUGIN_PLUGIN_ERROR_H