Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: utils/tests/pub/curl_client_test.dart

Issue 11881032: Stop working around issue 7781 in Pub. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « utils/pub/utils.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/tests/pub/curl_client_test.dart
diff --git a/utils/tests/pub/curl_client_test.dart b/utils/tests/pub/curl_client_test.dart
index 2baa84dd6d58335506345fc0e5a830d907df0ba7..eda16bf2062f21eb0b53368a8658d534e8706e04 100644
--- a/utils/tests/pub/curl_client_test.dart
+++ b/utils/tests/pub/curl_client_test.dart
@@ -168,12 +168,6 @@ class _Parse extends BaseMatcher {
}
}
-// ----------------------------------------------------------------------------
-
-// TODO(nweiz): All the code from here to the next "---..." line was also copied
-// from pkg/http/test/utils.dart. However, it was also modified to use
-// getRealError in order to work around issue 7781.
-
// TODO(nweiz): remove this once it's built in to unittest
/// A matcher for StateErrors.
const isStateError = const _StateError();
@@ -184,7 +178,7 @@ const Matcher throwsStateError =
class _StateError extends TypeMatcher {
const _StateError() : super("StateError");
- bool matches(item, MatchState matchState) => getRealError(item) is StateError;
+ bool matches(item, MatchState matchState) => item is StateError;
}
/// A matcher for HttpExceptions.
@@ -196,8 +190,7 @@ const Matcher throwsHttpException =
class _HttpException extends TypeMatcher {
const _HttpException() : super("HttpException");
- bool matches(item, MatchState matchState) =>
- getRealError(item) is HttpException;
+ bool matches(item, MatchState matchState) => item is HttpException;
}
/// A matcher for RedirectLimitExceededExceptions.
@@ -213,7 +206,7 @@ class _RedirectLimitExceededException extends TypeMatcher {
super("RedirectLimitExceededException");
bool matches(item, MatchState matchState) =>
- getRealError(item) is RedirectLimitExceededException;
+ item is RedirectLimitExceededException;
}
// ----------------------------------------------------------------------------
« no previous file with comments | « utils/pub/utils.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698