Move wifi_data_provider_chromeos -> content

content/browser/geolocation/device_data_provider.h

Index: content/browser/geolocation/device_data_provider.h
diff --git a/content/browser/geolocation/device_data_provider.h b/content/browser/geolocation/device_data_provider.h
index b1014ade13fab2bf713a0e1d9a3c9ecd8800fb78..4918e303d4c6ec5703e2890e66b58b51b60c8f01 100644
--- a/content/browser/geolocation/device_data_provider.h
+++ b/content/browser/geolocation/device_data_provider.h
@@ -125,9 +125,7 @@ class DeviceDataProviderImplBase : public DeviceDataProviderImplBaseHack {
   }
 
  protected:
-  virtual ~DeviceDataProviderImplBase() {
-    DCHECK(CalledOnClientThread());

[John Knottenbelt, 2013/01/14 14:12:31]

According to jam@, there are some tests that hold a reference to the provider
causing the last reference to be lost on the UI thread instead of the
geolocation thread.

It seems a shame to remove the guarantee that this class will always be
destroyed on the same thread its used on. Can you take a look and see if there
are any obvious fixes?

[stevenjb, 2013/01/14 18:02:38]

jam@, any thoughts? I just copied this, but I'm really not familiar wiht how
it's used. I could put the DCHECK back and see what fails...

That said, a DCHECK like this in the destructor is kind of unusual, and this
does derive from base::RefCountedThreadSafe, which implies to me that destroying
this on another thread should be valid?

[jam, 2013/01/14 18:57:21]

this check is just invalid because as you say the destruction of this object can
happen on different threads because of the ref counted. normally if we want to
add a dcheck like this, a traits on the object would ensure that it destructs on
a sepecific message loop. that can be done, but it seems out of scope of this
change.

the issue is not with a specific test that holds a reference. it's just that we
never used the cros implementation in tests for a long time, and that one seems
to post tasks differently from other tests which changes the ref counting

-  }
+  virtual ~DeviceDataProviderImplBase() {}
 
   // Calls DeviceDataUpdateAvailable() on all registered listeners.
   typedef std::set<ListenerInterface*> ListenersSet;