Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 1188093002: Revert of Decompiler improvements. (Closed)

Created:
5 years, 6 months ago by Michael Starzinger
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Decompiler improvements. (patchset #2 id:20001 of https://codereview.chromium.org/1177123002/) Reason for revert: Code printout has become unreadable. Offsets are printed in decimal numbers everywhere else. This is inconsistent with the rest of the code-base. Some examples are tables for deoptimization data, safepoints and exception handlers. I would be fine with this change if _all_ tracing would be adapted. But there are _many_ places to touch. Original issue's description: > Decompiler improvements. > > The main motivation is simplifying profiling activities: > > 1) Use hex instead of decimal for offsets, just like perf does. This > affects --print-opt-code > > 2) When printing block information, indicate loop information: if > block is header, where the end is; if block is in a loop, where the > loop starts. This affects --code-comments. > > Using --print-opt-code --code-comments, and cross-referencing with data > obtained from perf, one may now find the block a hotspot belongs to > without needing to do hex2dec/dec2hex conversions. Once found, loop info > is available locally, on the block. > > BUG= > > Committed: https://crrev.com/32f4bd659d38eb5485eedb1d0dd236ff1bdc01d5 > Cr-Commit-Position: refs/heads/master@{#28964} TBR=jarin@chromium.org,stichnot@chromium.org,jvoung@chromium.org,mtrofin@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/e2ce4681655a610631e6a6e17dec62e6c4bdef43 Cr-Commit-Position: refs/heads/master@{#29046}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -25 lines) Patch
M src/compiler/code-generator.cc View 1 chunk +6 lines, -23 lines 0 comments Download
M src/disassembler.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Starzinger
Created Revert of Decompiler improvements.
5 years, 6 months ago (2015-06-16 10:36:43 UTC) #1
Benedikt Meurer
LGTM.
5 years, 6 months ago (2015-06-16 10:37:44 UTC) #3
Jarin
lgtm
5 years, 6 months ago (2015-06-16 10:37:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1188093002/1
5 years, 6 months ago (2015-06-16 10:38:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-16 10:38:52 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-16 10:39:15 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e2ce4681655a610631e6a6e17dec62e6c4bdef43
Cr-Commit-Position: refs/heads/master@{#29046}

Powered by Google App Engine
This is Rietveld 408576698