Specify location of resource_ids with DEPTH instead of GRIT_DIR.

Specify location of resource_ids with DEPTH instead of GRIT_DIR.

This works around a MSVS bug which would change
'-f GRIT_DIR/../gritsettings/resource_ids' to '-f gritsettings/resource_ids'
and prepares for re-landing https://codereview.chromium.org/11659006/


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177025

[newt (away), 2013-01-15 19:55:35]

This can land after https://codereview.chromium.org/11906006/ goes in.

Last one!

Thanks!

[Sergey Ulanov, 2013-01-15 19:56:05]

lgtm

[joi, 2013-01-15 19:57:58]

LGTM, nice.

On Tue, Jan 15, 2013 at 11:56 AM,  <sergeyu@chromium.org> wrote:
> lgtm
>
>
>
> https://codereview.chromium.org/11880050/

[joi, 2013-01-15 19:58:47]

BTW: How do you plan to test? I would recommend actually looking at
the header files generated by grit (like generated_resources.h) before
and after this change to make sure the right start-IDs are being
picked up.

Cheers,
Jói


On Tue, Jan 15, 2013 at 11:57 AM, Jói Sigurðsson <joi@google.com> wrote:
> LGTM, nice.
>
> On Tue, Jan 15, 2013 at 11:56 AM,  <sergeyu@chromium.org> wrote:
>> lgtm
>>
>>
>>
>> https://codereview.chromium.org/11880050/

[newt (away), 2013-01-15 20:04:04]

Yes, I'll verify by looking at the headers.  Even just running gyp without
getting an error about a "missing .../resource_ids file" should be a sign
of success.

Best,
Newton


On Tue, Jan 15, 2013 at 11:58 AM, Jói Sigurðsson <joi@google.com> wrote:

> BTW: How do you plan to test? I would recommend actually looking at
> the header files generated by grit (like generated_resources.h) before
> and after this change to make sure the right start-IDs are being
> picked up.
>
> Cheers,
> Jói
>
>
> On Tue, Jan 15, 2013 at 11:57 AM, Jói Sigurðsson <joi@google.com> wrote:
> > LGTM, nice.
> >
> > On Tue, Jan 15, 2013 at 11:56 AM,  <sergeyu@chromium.org> wrote:
> >> lgtm
> >>
> >>
> >>
> >> https://codereview.chromium.org/11880050/
>

[joi, 2013-01-15 20:05:59]

Yes, I think so too (about the grit error message) but just in case
that's broken for any reason :)

On Tue, Jan 15, 2013 at 12:04 PM, Newton Allen <newt@chromium.org> wrote:
> Yes, I'll verify by looking at the headers.  Even just running gyp without
> getting an error about a "missing .../resource_ids file" should be a sign of
> success.
>
> Best,
> Newton
>
>
> On Tue, Jan 15, 2013 at 11:58 AM, Jói Sigurðsson <joi@google.com> wrote:
>>
>> BTW: How do you plan to test? I would recommend actually looking at
>> the header files generated by grit (like generated_resources.h) before
>> and after this change to make sure the right start-IDs are being
>> picked up.
>>
>> Cheers,
>> Jói
>>
>>
>> On Tue, Jan 15, 2013 at 11:57 AM, Jói Sigurðsson <joi@google.com> wrote:
>> > LGTM, nice.
>> >
>> > On Tue, Jan 15, 2013 at 11:56 AM,  <sergeyu@chromium.org> wrote:
>> >> lgtm
>> >>
>> >>
>> >>
>> >> https://codereview.chromium.org/11880050/
>
>

[newt (away), 2013-01-15 22:17:41]

On 2013/01/15 20:05:59, joi wrote:
> Yes, I think so too (about the grit error message) but just in case
> that's broken for any reason :)
> 
> On Tue, Jan 15, 2013 at 12:04 PM, Newton Allen <mailto:newt@chromium.org>
wrote:
> > Yes, I'll verify by looking at the headers.  Even just running gyp without
> > getting an error about a "missing .../resource_ids file" should be a sign of
> > success.
> >
> > Best,
> > Newton
> >
> >
> > On Tue, Jan 15, 2013 at 11:58 AM, Jói Sigurðsson <mailto:joi@google.com>
wrote:
> >>
> >> BTW: How do you plan to test? I would recommend actually looking at
> >> the header files generated by grit (like generated_resources.h) before
> >> and after this change to make sure the right start-IDs are being
> >> picked up.
> >>
> >> Cheers,
> >> Jói
> >>
> >>
> >> On Tue, Jan 15, 2013 at 11:57 AM, Jói Sigurðsson <mailto:joi@google.com>
wrote:
> >> > LGTM, nice.
> >> >
> >> > On Tue, Jan 15, 2013 at 11:56 AM,  <mailto:sergeyu@chromium.org> wrote:
> >> >> lgtm
> >> >>
> >> >>
> >> >>
> >> >> https://codereview.chromium.org/11880050/
> >
> >

Verified that the generated .h files are the same before and after this change.

[commit-bot: I haz the power, 2013-01-15 22:22:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/newt@chromium.org/11880050/1

[commit-bot: I haz the power, 2013-01-16 00:28:37]

Change committed as 177025