Issue 1188003006: Implement ColorFilter in widgets/basic.dart

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1188003006: Implement ColorFilter in widgets/basic.dart (Closed)

Created:
5 years, 6 months ago by abarth-chromium

Modified:
5 years, 6 months ago

Reviewers:
Hixie

CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, tonyg

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Implement ColorFilter in widgets/basic.dart Also, trim the redundant |Mode| suffix from the TransferMode names. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/3a60329240b379f47c9f48b34df5e6b48fa0e378

Patch Set 1 #

Total comments: 1

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+90 lines, -35 lines)			Patch
M	sky/engine/core/painting/TransferMode.dart	View	1 chunk	+29 lines, -29 lines	0 comments	Download
M	sky/examples/game/lib/game_demo_world.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sky/examples/game/lib/sprite.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/examples/raw/shadow.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/sdk/lib/painting/shadows.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/sdk/lib/rendering/box.dart	View	1 chunk	+37 lines, -1 line	1 comment	Download
M	sky/sdk/lib/widgets/basic.dart	View	2 chunks	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Hixie

lgtm https://codereview.chromium.org/1188003006/diff/1/sky/sdk/lib/rendering/box.dart File sky/sdk/lib/rendering/box.dart (right): https://codereview.chromium.org/1188003006/diff/1/sky/sdk/lib/rendering/box.dart#newcode495 sky/sdk/lib/rendering/box.dart:495: : this._color = color, _transferMode = transferMode, super(child) ...

5 years, 6 months ago (2015-06-17 23:59:13 UTC) #2

abarth-chromium

5 years, 6 months ago (2015-06-18 00:06:34 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3a60329240b379f47c9f48b34df5e6b48fa0e378 (presubmit successful).

Expand Messages | Collapse Messages