Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(6)

Issue 11880030: Merge 139024 (Closed)

Created:
7 years, 9 months ago by Xianzhu
Modified:
7 years, 9 months ago
Reviewers:
Xianzhu
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1364/
Visibility:
Public.

Description

Merge 139024 > Add a setting to enable composited scrolling for frames > https://bugs.webkit.org/show_bug.cgi?id=104950 > > Reviewed by James Robinson. > > Source/WebCore: > > Test: compositing/iframes/iframe-composited-scrolling.html > > * page/FrameView.cpp: > (WebCore::FrameView::usesCompositedScrolling): Returns true if compositedScrollingForFramesEnabled and the frame is in forced compositing mode (which is set when forced compositing mode and compositing for scrollable frames are enabled), so that ScrollingCoordinator won't include the region of the frame in the nonFastScrollableRegion. > (WebCore): > * page/FrameView.h: > (FrameView): > * page/Settings.in: Add compositedScrollingForFramesEnabled setting. > * page/scrolling/chromium/ScrollingCoordinatorChromium.cpp: > (WebCore::ScrollingCoordinatorChromium::frameViewLayoutUpdated): Changed the comment about which ScrollableAreas are non-fast-scrollable. > * rendering/RenderLayerCompositor.cpp: > (WebCore::RenderLayerCompositor::frameViewDidScroll): Let ScrollongCoordinator know when the scrolling changes for a frame with composited scrolling enabled. > > LayoutTests: > > Test case to ensure iframes are not added into nonFastScrollableRegion when acceleratedCompositingForScrollableFramesEnabled and compositedScrollingForFramesEnabled. > > * compositing/iframes/iframe-composited-scrolling-expected.txt: Added. > * compositing/iframes/iframe-composited-scrolling.html: Added. > TBR=wangxianzhu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139632

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
A + LayoutTests/compositing/iframes/iframe-composited-scrolling.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/compositing/iframes/iframe-composited-scrolling-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/page/FrameView.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/page/FrameView.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/WebCore/page/Settings.in View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/WebCore/rendering/RenderLayerCompositor.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Xianzhu
7 years, 9 months ago (2013-01-14 19:21:32 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698