Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Unified Diff: content/renderer/media/audio_renderer_mixer_manager.h

Issue 11880009: Introduce AudioHardwareConfig for renderer side audio device info. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comments. Collapse! Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/audio_renderer_mixer_manager.h
diff --git a/content/renderer/media/audio_renderer_mixer_manager.h b/content/renderer/media/audio_renderer_mixer_manager.h
index 20afcb83fd1944b61a709b983fde5da70b9b9a0e..cfa0545153ba240066228abf06c8d0f345624579 100644
--- a/content/renderer/media/audio_renderer_mixer_manager.h
+++ b/content/renderer/media/audio_renderer_mixer_manager.h
@@ -13,6 +13,7 @@
#include "media/audio/audio_parameters.h"
namespace media {
+class AudioHardwareConfig;
class AudioRendererMixer;
class AudioRendererMixerInput;
class AudioRendererSink;
@@ -36,7 +37,7 @@ namespace content {
class CONTENT_EXPORT AudioRendererMixerManager {
public:
// Construct an instance using the given audio hardware configuration.
- AudioRendererMixerManager(int hardware_sample_rate, int hardware_buffer_size);
+ AudioRendererMixerManager(media::AudioHardwareConfig* hardware_config);
scherkus (not reviewing) 2013/01/31 02:33:33 raw pointer scares me -- care to document the life
miu 2013/01/31 05:28:53 Drive-by comment: Add 'explicit' keyword here.
DaleCurtis 2013/01/31 19:50:00 Done.
DaleCurtis 2013/01/31 19:50:00 Done.
~AudioRendererMixerManager();
// Creates an AudioRendererMixerInput with the proper callbacks necessary to
@@ -82,8 +83,7 @@ class CONTENT_EXPORT AudioRendererMixerManager {
// Audio hardware configuration. Used to construct output AudioParameters for
// each AudioRendererMixer instance.
- int hardware_sample_rate_;
- int hardware_buffer_size_;
+ media::AudioHardwareConfig* const hardware_config_;
media::AudioRendererSink* sink_for_testing_;

Powered by Google App Engine
This is Rietveld 408576698