Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(76)

Issue 1187973007: Templatize LayoutView::commitPendingSelection function (Closed)

Created:
4 years, 10 months ago by yosin_UTC9
Modified:
4 years, 10 months ago
Reviewers:
tkent
CC:
blink-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-reviews-rendering, jchaffraix+rendering, hajimehoshi
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Templatize LayoutView::commitPendingSelection function This patch introduces a template function |commitPendingSelectionAlgorithm<Startegy>| to makes |LayoutView::commitPendingSelection()| function to work both on DOM tree and composed tree with introducing member functions to strategy class |VisibleSelection::InDOMTree|. This patch is result of collaboration work with hajimehoshi@chromium.org for selection of web components. After this patch, we are going to implement another strategies for the composed tree. We've already prepared that at http://crrev.com/1106433002. BUG=275851 TEST=n/a; No behavior changes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197320

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -5 lines) Patch
M Source/core/editing/VisibleSelection.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutView.h View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutView.cpp View 3 chunks +13 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
yosin_UTC9
PTAL
4 years, 10 months ago (2015-06-18 05:18:39 UTC) #2
tkent
lgtm
4 years, 10 months ago (2015-06-18 05:36:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187973007/1
4 years, 10 months ago (2015-06-18 05:36:55 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2015-06-18 05:57:19 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197320

Powered by Google App Engine
This is Rietveld 408576698