Issue 1187913002: Run install-build-deps in the middle of 'fetch chromium'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1187913002: Run install-build-deps in the middle of 'fetch chromium' (Closed)

Created:
5 years, 6 months ago by agable

Modified:
5 years, 6 months ago

Reviewers:
Michael Moss

CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Target Ref:
refs/heads/master

Project:
depot_tools

Visibility:
Public.

More Reviews

Description

Run install-build-deps in the middle of 'fetch chromium' R=mmoss@chromium.org BUG=229270 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295679

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
	M	fetch.py	View		3 chunks	+7 lines, -2 lines	0 comments	Download
	M	recipes/chromium.py	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187913002/1

5 years, 6 months ago (2015-06-15 19:14:11 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=295679

5 years, 6 months ago (2015-06-15 19:15:57 UTC) #5

Dirk Pranke

5 years, 6 months ago (2015-06-15 21:07:23 UTC) #6

Message was sent while issue was closed.

We only run install-build-deps on linux; unless I'm missing something, this'll
try to run it unconditionally on all platforms, no?

(We need to run install-build-deps-android.sh for android instead, and install
the toolchains on win and mac instead).

Also, I have a vague memory that we thought running install-build-deps was dodgy
because of either the need for sudo
or perhaps other side effects, but perhaps I'm being overly paranoid here?

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages