Improve the error-propagation on socket streams

Improve the error-propagation on socket streams

R=ager@google.com, ajohnsen@google.com

BUG=dart:7334
Committed: https://code.google.com/p/dart/source/detail?r=17064

[Mads Ager (google), 2013-01-15 12:39:03]

LGTM with path in test changed.

https://codereview.chromium.org/11879042/diff/1/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/11879042/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:880: _onClosed();
Indentation off by one.

https://codereview.chromium.org/11879042/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:889: _isRequestDone &&
Could you explain why this isn't !_isResponseDone?

Also, align the rest of the condition:

} else if (_response != null &&
           _isRequestDone &&
           _response._streamErrorHandler != null) {
  ...

?

https://codereview.chromium.org/11879042/diff/1/tests/standalone/io/http_serv...
File tests/standalone/io/http_server_early_client_close_test.dart (right):

https://codereview.chromium.org/11879042/diff/1/tests/standalone/io/http_serv...
tests/standalone/io/http_server_early_client_close_test.dart:103: new
File("test.dart").openInputStream().pipe(response.outputStream);
Do you want it to find a file here? I guess you just want any data, really. How
about using: new Options().script?

[Anders Johnsen, 2013-01-15 12:39:37]

LGTM

[Søren Gjesse, 2013-01-15 12:57:45]

https://codereview.chromium.org/11879042/diff/1/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/11879042/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:880: _onClosed();
On 2013/01/15 12:39:03, Mads Ager wrote:
> Indentation off by one.

Not really - did you miss the underscore?

https://codereview.chromium.org/11879042/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:889: _isRequestDone &&
On 2013/01/15 12:39:03, Mads Ager wrote:
> Could you explain why this isn't !_isResponseDone?
> 
> Also, align the rest of the condition:
> 
> } else if (_response != null &&
>            _isRequestDone &&
>            _response._streamErrorHandler != null) {
>   ...
> 
> ?

Artifact of refactoring. Changed to !isResponseDone.

https://codereview.chromium.org/11879042/diff/1/tests/standalone/io/http_serv...
File tests/standalone/io/http_server_early_client_close_test.dart (right):

https://codereview.chromium.org/11879042/diff/1/tests/standalone/io/http_serv...
tests/standalone/io/http_server_early_client_close_test.dart:103: new
File("test.dart").openInputStream().pipe(response.outputStream);
On 2013/01/15 12:39:03, Mads Ager wrote:
> Do you want it to find a file here? I guess you just want any data, really.
How
> about using: new Options().script?

Done, thanks.

[Mads Ager (google), 2013-01-15 13:24:01]

https://codereview.chromium.org/11879042/diff/1/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/11879042/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:880: _onClosed();
On 2013/01/15 12:57:45, Søren Gjesse wrote:
> On 2013/01/15 12:39:03, Mads Ager wrote:
> > Indentation off by one.
> 
> Not really - did you miss the underscore?

I did, yes. Thanks! :-)