Issue 11879031: [Android] Move base tests classes to pylib/base

Issue 11879031: [Android] Move base tests classes to pylib/base (Closed)

Created:
7 years, 11 months ago by frankf

Modified:
7 years, 11 months ago

Reviewers:
craigdh, bulach

CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Android] Move base tests classes to pylib/base BUG=168727 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177252

Patch Set 4 : Fixed nits #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -708 lines)			Patch
A +	build/android/pylib/base/__init__.py	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	build/android/pylib/base/base_test_runner.py	View		1 chunk	+8 lines, -8 lines	0 comments	Download
A +	build/android/pylib/base/base_test_sharder.py	View	1 2 3	3 chunks	+5 lines, -6 lines	0 comments	Download
A +	build/android/pylib/base/sharded_tests_queue.py	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	build/android/pylib/base/test_result.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download
D	build/android/pylib/base_test_runner.py	View		1 chunk	+0 lines, -210 lines	0 comments	Download
D	build/android/pylib/base_test_sharder.py	View		1 chunk	+0 lines, -153 lines	0 comments	Download
M	build/android/pylib/gtest/single_test_runner.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	build/android/pylib/gtest/test_package.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	build/android/pylib/host_driven/python_test_base.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	build/android/pylib/host_driven/python_test_caller.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	build/android/pylib/host_driven/python_test_sharder.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	build/android/pylib/host_driven/run_python_tests.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	build/android/pylib/instrumentation/run_java_tests.py	View		1 chunk	+4 lines, -4 lines	0 comments	Download
D	build/android/pylib/sharded_tests_queue.py	View		1 chunk	+0 lines, -35 lines	0 comments	Download
D	build/android/pylib/test_result.py	View		1 chunk	+0 lines, -281 lines	0 comments	Download
M	build/android/run_instrumentation_tests.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	build/android/run_monkey_test.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	build/android/run_tests.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

craigdh

lgtm. https://codereview.chromium.org/11879031/diff/6021/build/android/pylib/base/base_test_sharder.py File build/android/pylib/base/base_test_sharder.py (right): https://codereview.chromium.org/11879031/diff/6021/build/android/pylib/base/base_test_sharder.py#newcode10 build/android/pylib/base/base_test_sharder.py:10: from pylib.android_commands import errors Just change the 2 ...

7 years, 11 months ago (2013-01-15 23:00:05 UTC) #2

bulach

lgtm, nice clean up, thanks! https://codereview.chromium.org/11879031/diff/6021/build/android/pylib/base/base_test_sharder.py File build/android/pylib/base/base_test_sharder.py (right): https://codereview.chromium.org/11879031/diff/6021/build/android/pylib/base/base_test_sharder.py#newcode12 build/android/pylib/base/base_test_sharder.py:12: from pylib.forwarder import Forwarder ...

7 years, 11 months ago (2013-01-16 09:45:50 UTC) #3

frankf

7 years, 11 months ago (2013-01-16 21:34:03 UTC) #4

https://codereview.chromium.org/11879031/diff/6021/build/android/pylib/base/b...
File build/android/pylib/base/base_test_sharder.py (right):

https://codereview.chromium.org/11879031/diff/6021/build/android/pylib/base/b...
build/android/pylib/base/base_test_sharder.py:10: from pylib.android_commands
import errors
On 2013/01/15 23:00:05, craigdh wrote:
> Just change the 2 uses of this to android_commands.errors and get rid of this
> import.

Done.

https://codereview.chromium.org/11879031/diff/6021/build/android/pylib/base/b...
build/android/pylib/base/base_test_sharder.py:12: from pylib.forwarder import
Forwarder
I rather do this in a separate CL.

On 2013/01/16 09:45:50, bulach wrote:
> On 2013/01/15 23:00:05, craigdh wrote:
> > Should forwarder be in utils?
> 
> if you do change this, please remember that "forwarder" is also used by
> telemetry (tools/telemetry/telemetry/adb_commands.py), and iirc, webkit..

Expand Messages | Collapse Messages