Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 1187903003: Fix invalid depfile generation in generate_split_manifest.py (Closed)

Created:
5 years, 6 months ago by agrieve
Modified:
5 years, 6 months ago
Reviewers:
cjhopman
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix invalid depfile generation in generate_split_manifest.py This caused ninja to crash for incremental builds of ChromeModern.apk BUG=447152 Committed: https://crrev.com/afad5c2282c80622b28d112f757fe3d6c06dfa1a Cr-Commit-Position: refs/heads/master@{#335060}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/android/gyp/generate_split_manifest.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
agrieve
5 years, 6 months ago (2015-06-15 19:07:50 UTC) #2
cjhopman
lgtm
5 years, 6 months ago (2015-06-17 21:19:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187903003/1
5 years, 6 months ago (2015-06-18 00:30:10 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/7503)
5 years, 6 months ago (2015-06-18 02:00:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187903003/1
5 years, 6 months ago (2015-06-18 15:39:28 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-18 16:26:27 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-18 16:27:25 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/afad5c2282c80622b28d112f757fe3d6c06dfa1a
Cr-Commit-Position: refs/heads/master@{#335060}

Powered by Google App Engine
This is Rietveld 408576698