base: Add a couple Pref unit tests to base_unittests target.

chrome/chrome_tests_unit.gypi

 # Copyright 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 {
   'targets': [
     {
       # This target contains mocks and test utilities that don't belong in
       # production libraries but are used by more than one test executable.
       'target_name': 'test_support_common',
       'type': 'static_library',
       'dependencies': [
         # NOTE: New dependencies should generally be added in the OS!="ios"
         # dependencies block below, rather than here.
         'app/policy/cloud_policy_codegen.gyp:policy_test_support',
         'browser',
         '../sync/protocol/sync_proto.gyp:sync_proto',
         'chrome_resources.gyp:chrome_resources',
         'chrome_resources.gyp:chrome_strings',
         'chrome_resources.gyp:theme_resources',
         'common',
         '../base/base.gyp:test_support_base',
+        '../base/base.gyp:base_prefs_test_support',
         '../content/content.gyp:content_app',
         '../content/content.gyp:test_support_content',
         '../media/media.gyp:media_test_support',
         '../net/net.gyp:net',
         '../net/net.gyp:net_test_support',
         '../skia/skia.gyp:skia',
         '../testing/gmock.gyp:gmock',
         '../testing/gtest.gyp:gtest',
       ],
       'export_dependent_settings': [
@@ skipping 214 matching lines @@
         'test/logging/win/log_file_printer.h',
         'test/logging/win/log_file_reader.cc',
         'test/logging/win/log_file_reader.h',
         'test/logging/win/mof_data_parser.cc',
         'test/logging/win/mof_data_parser.h',
         'test/logging/win/test_log_collector.cc',
         'test/logging/win/test_log_collector.h',
         'test/ppapi/ppapi_test.cc',
         'test/ppapi/ppapi_test.h',
 
-        # TODO(joi): Move to 'base_prefs' target in base/base.gyp once
-        # Prefs move is complete and dependencies have been broken.
-        '../base/prefs/testing_pref_store.cc',
-        '../base/prefs/testing_pref_store.h',
-        '../base/prefs/pref_store_observer_mock.cc',
-        '../base/prefs/pref_store_observer_mock.h',
-
         '../ui/gfx/image/image_unittest_util.h',
         '../ui/gfx/image/image_unittest_util.cc',
         '../webkit/quota/mock_quota_manager.cc',
         '../webkit/quota/mock_quota_manager.h',
       ],
       'conditions': [
         ['OS!="ios"', {
           'dependencies': [
             'common/extensions/api/api.gyp:api',
             'plugin',
@@ skipping 1313 matching lines @@
         'test/base/menu_model_test.h',
         'test/base/v8_unit_test.cc',
         'test/base/v8_unit_test.h',
         'test/data/resource.rc',
         'test/data/unit/framework_unittest.gtestjs',
         'test/logging/win/mof_data_parser_unittest.cc',
         'tools/convert_dict/convert_dict_unittest.cc',
 
         # TODO(joi): Move to 'base_prefs' target in base/base.gyp once
         # Prefs move is complete and dependencies have been broken.
+        '../base/prefs/json_pref_store_unittest.cc',

[tfarina, 2013/01/19 20:50:59]

We can move it back to base_unittests and exclude it when OS equal ios.

Would be that fine, Joi?

[Jói, 2013/01/21 10:33:22]

If that passes all bots then I have no issue with it.

         '../base/prefs/public/pref_change_registrar_unittest.cc',
         '../base/prefs/public/pref_member_unittest.cc',
-        '../base/prefs/overlay_user_pref_store_unittest.cc',
-        '../base/prefs/pref_value_map_unittest.cc',
-        '../base/prefs/json_pref_store_unittest.cc',
 
         # TODO(joi): Move the google_apis tests to a separate
         # google_apis_unittests executable.
         '../google_apis/google_api_keys_unittest.cc',
         '../google_apis/gaia/mock_url_fetcher_factory.h',
         '../google_apis/gaia/gaia_auth_fetcher_unittest.cc',
         '../google_apis/gaia/gaia_auth_util_unittest.cc',
         '../google_apis/gaia/gaia_authenticator_unittest.cc',
         '../google_apis/gaia/gaia_oauth_client_unittest.cc',
         '../google_apis/gaia/google_service_auth_error_unittest.cc',
@@ skipping 718 matching lines @@
             'unit_tests.isolate',
           ],
           'sources': [
             'unit_tests.isolate',
           ],
         },
       ],
     }],
   ],  # 'conditions'
 }