cc: Redraw incomplete frames when new texture uploads finish

cc/layer_tree_host_impl.cc

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/layer_tree_host_impl.h"
 
 #include <algorithm>
 
 #include "base/basictypes.h"
 #include "base/debug/trace_event.h"
@@ skipping 454 matching lines @@
         occlusionTracker.setNonOccludingScreenSpaceRectsContainer(&frame.nonOccludingScreenSpaceRects);
 
     // Add quads to the Render passes in FrontToBack order to allow for testing occlusion and performing culling during the tree walk.
     typedef LayerIterator<LayerImpl, std::vector<LayerImpl*>, RenderSurfaceImpl, LayerIteratorActions::FrontToBack> LayerIteratorType;
 
     // Typically when we are missing a texture and use a checkerboard quad, we still draw the frame. However when the layer being
     // checkerboarded is moving due to an impl-animation, we drop the frame to avoid flashing due to the texture suddenly appearing
     // in the future.
     bool drawFrame = true;
 
-    // Make sure we have the most recent info regarding which textures have been uploaded.
-    checkForCompletedSetPixels();
-
     LayerIteratorType end = LayerIteratorType::end(frame.renderSurfaceLayerList);
     for (LayerIteratorType it = LayerIteratorType::begin(frame.renderSurfaceLayerList); it != end; ++it) {
         RenderPass::Id targetRenderPassId = it.targetRenderSurfaceLayer()->renderSurface()->renderPassId();
         RenderPass* targetRenderPass = frame.renderPassesById[targetRenderPassId];
 
         occlusionTracker.enterLayer(it);
 
         AppendQuadsData appendQuadsData(targetRenderPass->id);
 
         if (it.representsContributingRenderSurface()) {
@@ skipping 227 matching lines @@
 {
     return m_proxy->hasImplThread();
 }
 
 void LayerTreeHostImpl::ScheduleManageTiles()
 {
     if (m_client)
       m_client->setNeedsManageTilesOnImplThread();
 }
 
+void LayerTreeHostImpl::DidUploadVisibleHighResolutionTile()
+{
+    if (m_client)
+        m_client->didUploadVisibleHighResolutionTileOnImplTread();
+}
+
 bool LayerTreeHostImpl::shouldClearRootRenderPass() const
 {
     return m_settings.shouldClearRootRenderPass;
 }
 
 void LayerTreeHostImpl::setManagedMemoryPolicy(const ManagedMemoryPolicy& policy)
 {
     if (m_managedMemoryPolicy == policy)
         return;
 
@@ skipping 106 matching lines @@
 }
 
 const RendererCapabilities& LayerTreeHostImpl::rendererCapabilities() const
 {
     return m_renderer->capabilities();
 }
 
 bool LayerTreeHostImpl::swapBuffers()
 {
     DCHECK(m_renderer);
-    return m_renderer->swapBuffers();
+    bool result = m_renderer->swapBuffers();
+
+    if (m_settings.implSidePainting &&
+        !activeTree()->AreVisibleResourcesReady()) {
+        m_client->didSwapUseIncompleteTextureOnImplThread();
+    }
+
+    return result;
 }
 
 const gfx::Size& LayerTreeHostImpl::deviceViewportSize() const
 {
     return m_deviceViewportSize;
 }
 
 const LayerTreeSettings& LayerTreeHostImpl::settings() const
 {
     return m_settings;
@@ skipping 53 matching lines @@
 }
 
 void LayerTreeHostImpl::createPendingTree()
 {
     CHECK(!m_pendingTree);
     m_pendingTree = LayerTreeImpl::create(this);
     m_client->onCanDrawStateChanged(canDraw());
     m_client->onHasPendingTreeStateChanged(pendingTree());
 }
 
+// This function should not be called from within a draw, as it can trigger
+// as spurious draw if a new visible tile gets upload.
 void LayerTreeHostImpl::checkForCompletedSetPixels()
 {

[nduca, 2013/01/17 22:05:18]

Please add a member bool inside_draw_ and then do dcheck on it, then change this
comment to be a comment above the decheck or even better DCHECK(!inside_draw_)
<< "explanation"

[brianderson, 2013/01/18 00:08:18]

Decided to add and use LayerTreeHostImplClient::isInsideDraw because the proxies
knows best if we are inside a draw.

     if (m_tileManager)
         m_tileManager->CheckForCompletedSetPixels();
 }
 
 void LayerTreeHostImpl::activatePendingTreeIfNeeded()
 {
     if (!pendingTree())
         return;
 
-    checkForCompletedSetPixels();
-
     // It's always fine to activate to an empty tree.  Otherwise, only
     // activate once all visible resources in pending tree are ready.
     if (activeTree()->RootLayer() &&
         !pendingTree()->AreVisibleResourcesReady())
       return;
 
     activatePendingTree();
 }
 
 void LayerTreeHostImpl::activatePendingTree()
@@ skipping 723 matching lines @@
 }
 
 skia::RefPtr<SkPicture> LayerTreeHostImpl::capturePicture()
 {
     LayerTreeImpl* tree = pendingTree() ? pendingTree() : activeTree();
     LayerImpl* layer = getNonCompositedContentLayerRecursive(tree->RootLayer());
     return layer ? layer->getPicture() : skia::RefPtr<SkPicture>();
 }
 
 }  // namespace cc