scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets.json - Issue 1187863002: Use simpler "analyze" logic for chromium_trybot recipe on non-Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets.json

Issue 1187863002: Use simpler "analyze" logic for chromium_trybot recipe on non-Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_matching_exclusion.json ('k') | scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets_exclude_all.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets.json

diff --git a/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets.json b/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets.json

index 5438385d05df108e5754464433ea7b89d9ba2656..fe93f9be577a5e4fe664a98d740c96e046d562cb 100644

--- a/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets.json

+++ b/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets.json

@@ -228,8 +228,8 @@

"@@@STEP_LOG_LINE@analyze_details@{@@@",

"@@@STEP_LOG_LINE@analyze_details@ \"compile_targets\": [@@@",

"@@@STEP_LOG_LINE@analyze_details@ \"chrome\", @@@",

- "@@@STEP_LOG_LINE@analyze_details@ \"base_unittests\", @@@",

- "@@@STEP_LOG_LINE@analyze_details@ \"browser_tests\"@@@",

+ "@@@STEP_LOG_LINE@analyze_details@ \"browser_tests\", @@@",

+ "@@@STEP_LOG_LINE@analyze_details@ \"base_unittests\"@@@",

"@@@STEP_LOG_LINE@analyze_details@ ], @@@",

"@@@STEP_LOG_LINE@analyze_details@ \"original_compile_targets\": [@@@",

"@@@STEP_LOG_LINE@analyze_details@ \"angle_unittests_run\", @@@",

@@ -289,8 +289,8 @@

"--ninja-ensure-up-to-date",

"--",

"chrome",

- "base_unittests",

- "browser_tests"

+ "browser_tests",

+ "base_unittests"

"cwd": "[SLAVE_BUILD]",

"name": "compile (with patch)"