Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: third_party/polymer/v1_0/components/paper-toolbar/paper-toolbar.html

Issue 1187823002: Update Polymer components and re-run reproduce.sh (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/polymer/v1_0/components/paper-toolbar/paper-toolbar.html
diff --git a/third_party/polymer/v1_0/components/paper-toolbar/paper-toolbar.html b/third_party/polymer/v1_0/components/paper-toolbar/paper-toolbar.html
index 1bee9c32bc661798407ae94bb1e711f3eabcde66..153305e27f66df10c7e85a06f21b740bb84ee182 100644
--- a/third_party/polymer/v1_0/components/paper-toolbar/paper-toolbar.html
+++ b/third_party/polymer/v1_0/components/paper-toolbar/paper-toolbar.html
@@ -21,8 +21,8 @@ Example:
<paper-toolbar>
<paper-icon-button icon="menu" on-tap="menuAction"></paper-icon-button>
- <div title>Title</div>
- <paper-icon-button icon="more" on-tap="moreAction"></paper-icon-button>
+ <div class="title">Title</div>
+ <paper-icon-button icon="more-vert" on-tap="moreAction"></paper-icon-button>
</paper-toolbar>
`paper-toolbar` has a standard height, but can made be taller by setting `tall`
@@ -44,8 +44,8 @@ When `tall`, items can pin to either the top (default), middle or bottom. Use
<paper-toolbar class="tall">
<paper-icon-button icon="menu"></paper-icon-button>
- <div title class="middle">Middle Title</div>
- <div title class="bottom">Bottom Title</div>
+ <div class="middle title">Middle Title</div>
+ <div class="bottom title">Bottom Title</div>
</paper-toolbar>
For `medium-tall` toolbar, the middle and bottom contents overlap and are
@@ -64,7 +64,7 @@ Custom property | Description | Default
### Accessibility
-`<paper-toolbar>` has `role="toolbar"` by default. Any elements with the `title` attribute will
+`<paper-toolbar>` has `role="toolbar"` by default. Any elements with the class `title` will
be used as the label of the toolbar via `aria-labelledby`.
@demo demo/index.html
@@ -133,7 +133,6 @@ be used as the label of the toolbar via `aria-labelledby`.
#topBar {
position: relative;
- z-index: 1;
}
/* middle bar */
@@ -142,7 +141,6 @@ be used as the label of the toolbar via `aria-labelledby`.
top: 0;
right: 0;
left: 0;
- z-index: 2;
}
:host(.tall) #middleBar,
@@ -157,7 +155,6 @@ be used as the label of the toolbar via `aria-labelledby`.
right: 0;
bottom: 0;
left: 0;
- z-index: 1;
}
/*
@@ -171,10 +168,11 @@ be used as the label of the toolbar via `aria-labelledby`.
pointer-events: auto;
}
- .toolbar-tools > ::content [title] {
+ .toolbar-tools > ::content .title {
@apply(--paper-font-title);
@apply(--layout-flex);
+ pointer-events: none;
text-overflow: ellipsis;
white-space: nowrap;
overflow: hidden;
@@ -194,23 +192,18 @@ be used as the label of the toolbar via `aria-labelledby`.
* Work in progress.
*/
.toolbar-tools > ::content paper-icon-button[icon=menu] {
- margin-left: -8px;
margin-right: 24px;
}
- .toolbar-tools > ::content paper-icon-button + paper-icon-button {
- margin-right: -8px;
- }
-
- .toolbar-tools > ::content > [title],
- .toolbar-tools > ::content[select=".middle"] > [title],
- .toolbar-tools > ::content[select=".bottom"] > [title] {
+ .toolbar-tools > ::content > .title,
+ .toolbar-tools > ::content[select=".middle"] > .title,
+ .toolbar-tools > ::content[select=".bottom"] > .title {
margin-left: 56px;
}
- .toolbar-tools > ::content > paper-icon-button + [title],
- .toolbar-tools > ::content[select=".middle"] paper-icon-button + [title],
- .toolbar-tools > ::content[select=".bottom"] paper-icon-button + [title] {
+ .toolbar-tools > ::content > paper-icon-button + .title,
+ .toolbar-tools > ::content[select=".middle"] paper-icon-button + .title,
+ .toolbar-tools > ::content[select=".bottom"] paper-icon-button + .title {
margin-left: 0;
}
</style>
@@ -331,7 +324,7 @@ be used as the label of the toolbar via `aria-labelledby`.
for (var content, index = 0; content = contents[index]; index++) {
var nodes = Polymer.dom(content).getDistributedNodes();
for (var node, jndex = 0; node = nodes[jndex]; jndex++) {
- if (node.hasAttribute && node.hasAttribute('title')) {
+ if (node.classList && node.classList.contains('title')) {
if (node.id) {
labelledBy.push(node.id);
} else {

Powered by Google App Engine
This is Rietveld 408576698