Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: third_party/polymer/v1_0/components/iron-jsonp-library/iron-jsonp-library.html

Issue 1187823002: Update Polymer components and re-run reproduce.sh (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/polymer/v1_0/components/iron-jsonp-library/iron-jsonp-library.html
diff --git a/third_party/polymer/v1_0/components/iron-jsonp-library/iron-jsonp-library.html b/third_party/polymer/v1_0/components/iron-jsonp-library/iron-jsonp-library.html
index e4c04b5e3934b1d0964a330a10a8b9666b069353..63c60a3107913e131c346c0c6ecc65db2e4cd18a 100644
--- a/third_party/polymer/v1_0/components/iron-jsonp-library/iron-jsonp-library.html
+++ b/third_party/polymer/v1_0/components/iron-jsonp-library/iron-jsonp-library.html
@@ -23,6 +23,7 @@ subject to an additional IP rights grant found at http://polymer.github.io/PATEN
when possible instead of using this element.
@hero hero.svg
+ @demo demo/index.html
@polymerBehavior
*/
Polymer.IronJsonpLibraryBehavior = {
@@ -98,14 +99,14 @@ subject to an additional IP rights grant found at http://polymer.github.io/PATEN
}
};
- /*
+ /**
* LoaderMap keeps track of all Loaders
*/
var LoaderMap = {
apiMap: {}, // { hash -> Loader }
- /*
- * @param {function} notifyCallback loaded callback fn(result)
+ /**
+ * @param {Function} notifyCallback loaded callback fn(result)
* @param {string} jsonpCallbackName name of jsonpcallback. If API does not provide it, leave empty. Optional.
*/
require: function(url, notifyCallback, jsonpCallbackName) {
@@ -126,6 +127,7 @@ subject to an additional IP rights grant found at http://polymer.github.io/PATEN
}
};
+ /** @constructor */
var Loader = function(name, url, callbackName) {
this.notifiers = []; // array of notifyFn [ notifyFn* ]
@@ -184,7 +186,7 @@ subject to an additional IP rights grant found at http://polymer.github.io/PATEN
delete window[this.callbackName];
},
- notifyAll: function(notifyCallback) {
+ notifyAll: function() {
this.notifiers.forEach( function(notifyCallback) {
notifyCallback(this.error, this.result);
}.bind(this));

Powered by Google App Engine
This is Rietveld 408576698