Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: third_party/polymer/v1_0/components/paper-input/paper-input-container.html

Issue 1187823002: Update Polymer components and re-run reproduce.sh (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/polymer/v1_0/components/paper-input/paper-input-container.html
diff --git a/third_party/polymer/v1_0/components/paper-input/paper-input-container.html b/third_party/polymer/v1_0/components/paper-input/paper-input-container.html
index 18935c153b5bb152d4dcff26dca4c8c23404615f..e9088c26df2d3bbe04e4fb3cbcb41ed59facc818 100644
--- a/third_party/polymer/v1_0/components/paper-input/paper-input-container.html
+++ b/third_party/polymer/v1_0/components/paper-input/paper-input-container.html
@@ -109,7 +109,7 @@ This element is `display:block` by default, but you can set the `inline` attribu
background: var(--paper-input-container-focus-color, --default-primary-color);
}
- .is-highlighted .focused-line {
+ .underline.is-highlighted .focused-line {
-webkit-transform: none;
transform: none;
-webkit-transition: -webkit-transform 0.25s;
@@ -118,7 +118,7 @@ This element is `display:block` by default, but you can set the `inline` attribu
@apply(--paper-transition-easing);
}
- .is-invalid .focused-line {
+ .underline.is-invalid .focused-line {
background: var(--paper-input-container-invalid-color, --google-red-500);
-webkit-transform: none;
@@ -305,10 +305,10 @@ This element is `display:block` by default, but you can set the `inline` attribu
},
_addons: {
- type: Array,
- value: function() {
- return [];
- }
+ type: Array
+ // do not set a default value here intentionally - it will be initialized lazily when a
+ // distributed child is attached, which may occur before configuration for this element
+ // in polyfill.
},
_inputHasContent: {
@@ -338,7 +338,7 @@ This element is `display:block` by default, but you can set the `inline` attribu
_boundOnInput: {
type: Function,
value: function() {
- this._onInput.bind(this)
+ return this._onInput.bind(this);
}
},
@@ -369,6 +369,9 @@ This element is `display:block` by default, but you can set the `inline` attribu
},
ready: function() {
+ if (!this._addons) {
+ this._addons = [];
+ }
this.addEventListener('focus', this._boundOnFocus, true);
this.addEventListener('blur', this._boundOnBlur, true);
if (this.attrForValue) {
@@ -383,8 +386,16 @@ This element is `display:block` by default, but you can set the `inline` attribu
},
_onAddonAttached: function(event) {
- this._addons.push(event.target);
- this._handleValue(this._inputElement);
+ if (!this._addons) {
+ this._addons = [];
+ }
+ var target = event.target;
+ if (this._addons.indexOf(target) === -1) {
+ this._addons.push(target);
+ if (this.isAttached) {
+ this._handleValue(this._inputElement);
+ }
+ }
},
_onFocus: function() {

Powered by Google App Engine
This is Rietveld 408576698