Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: third_party/polymer/v1_0/components/paper-scroll-header-panel/paper-scroll-header-panel.html

Issue 1187823002: Update Polymer components and re-run reproduce.sh (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/polymer/v1_0/components/paper-scroll-header-panel/paper-scroll-header-panel.html
diff --git a/third_party/polymer/v1_0/components/paper-scroll-header-panel/paper-scroll-header-panel.html b/third_party/polymer/v1_0/components/paper-scroll-header-panel/paper-scroll-header-panel.html
index 3cb82f1b0620815405612e0d43ef7b5571fca930..740e9c7ca217a13dc90ce92b6629f8987f1bfd5f 100644
--- a/third_party/polymer/v1_0/components/paper-scroll-header-panel/paper-scroll-header-panel.html
+++ b/third_party/polymer/v1_0/components/paper-scroll-header-panel/paper-scroll-header-panel.html
@@ -41,7 +41,7 @@ or, if you would prefer to do it in CSS, just give `html`, `body`, and `paper-sc
}
`paper-scroll-header-panel` works well with `paper-toolbar` but can use any element
-that represents a header by adding a `core-header` class to it.
+that represents a header by adding a `paper-header` class to it.
<paper-scroll-header-panel>
<paper-toolbar>Header</paper-toolbar>
@@ -378,7 +378,7 @@ Styling scroll-header-panel:
_condenseHeader: function(y) {
var reset = (y === null);
- // adjust top bar in core-header so the top bar stays at the top
+ // adjust top bar in paper-header so the top bar stays at the top
if (!this.scrollAwayTopbar && this.header.$ && this.header.$.topBar) {
this._translateY(this.header.$.topBar.style,
reset ? null : Math.min(y, this._headerMargin));
@@ -406,6 +406,7 @@ Styling scroll-header-panel:
setTransform(s, t);
},
+ /** @param {Event=} event */
_scroll: function(event) {
if (!this.header) {
return;
@@ -432,7 +433,7 @@ Styling scroll-header-panel:
this._y = y;
if (event) {
- this.fire('content-scroll', {target: this.scroller}, this, false);
+ this.fire('content-scroll', {target: this.scroller}, {cancelable: false});
}
}

Powered by Google App Engine
This is Rietveld 408576698