Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Unified Diff: media/audio/audio_output_device_unittest.cc

Issue 11878032: Plumb |input_channels| all the way to AudioManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/audio/audio_output_device.cc ('k') | media/audio/audio_output_ipc.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/audio_output_device_unittest.cc
===================================================================
--- media/audio/audio_output_device_unittest.cc (revision 181072)
+++ media/audio/audio_output_device_unittest.cc (working copy)
@@ -52,8 +52,8 @@
MOCK_METHOD1(AddDelegate, int(AudioOutputIPCDelegate* delegate));
MOCK_METHOD1(RemoveDelegate, void(int stream_id));
- MOCK_METHOD3(CreateStream,
- void(int stream_id, const AudioParameters& params, int input_channels));
+ MOCK_METHOD2(CreateStream,
+ void(int stream_id, const AudioParameters& params));
MOCK_METHOD1(PlayStream, void(int stream_id));
MOCK_METHOD1(CloseStream, void(int stream_id));
MOCK_METHOD2(SetVolume, void(int stream_id, double volume));
@@ -110,7 +110,7 @@
// Must remain the first member of this class.
base::ShadowingAtExitManager at_exit_manager_;
MessageLoopForIO io_loop_;
- const AudioParameters default_audio_parameters_;
+ AudioParameters default_audio_parameters_;
StrictMock<MockRenderCallback> callback_;
StrictMock<MockAudioOutputIPC> audio_output_ipc_;
scoped_refptr<AudioOutputDevice> audio_device_;
@@ -148,25 +148,22 @@
}
AudioOutputDeviceTest::AudioOutputDeviceTest()
- : default_audio_parameters_(AudioParameters::AUDIO_PCM_LINEAR,
- CHANNEL_LAYOUT_STEREO,
- 48000, 16, 1024),
- synchronized_io_(GetParam()),
+ : synchronized_io_(GetParam()),
input_channels_(synchronized_io_ ? 2 : 0) {
+ default_audio_parameters_.Reset(
+ AudioParameters::AUDIO_PCM_LINEAR,
+ CHANNEL_LAYOUT_STEREO, input_channels_,
+ 48000, 16, 1024);
+
EXPECT_CALL(audio_output_ipc_, AddDelegate(_))
.WillOnce(Return(kStreamId));
audio_device_ = new AudioOutputDevice(
&audio_output_ipc_, io_loop_.message_loop_proxy());
- if (synchronized_io_) {
- audio_device_->InitializeIO(default_audio_parameters_,
- input_channels_,
- &callback_);
- } else {
- audio_device_->Initialize(default_audio_parameters_,
- &callback_);
- }
+ audio_device_->Initialize(default_audio_parameters_,
+ &callback_);
+
io_loop_.RunUntilIdle();
}
@@ -179,7 +176,7 @@
void AudioOutputDeviceTest::StartAudioDevice() {
audio_device_->Start();
- EXPECT_CALL(audio_output_ipc_, CreateStream(kStreamId, _, _));
+ EXPECT_CALL(audio_output_ipc_, CreateStream(kStreamId, _));
io_loop_.RunUntilIdle();
}
« no previous file with comments | « media/audio/audio_output_device.cc ('k') | media/audio/audio_output_ipc.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698