Default constructor for dart:io Path now handles native Windows paths. Path() now does the same as…

Default constructor for dart:io Path now handles native Windows paths.  Path() now does the same as Path.fromNative().  Path.fromNative() is removed, and all uses of it replaced by Path().


BUG=https://code.google.com/p/dart/issues/detail?id=7872

Committed: https://code.google.com/p/dart/source/detail?r=17026

[Mads Ager (google), 2013-01-14 12:33:34]

LGTM, but I would remove the fromNative constructor as part of this change and
update uses in our repo.

https://codereview.chromium.org/11878015/diff/2001/sdk/lib/io/path.dart
File sdk/lib/io/path.dart (right):

https://codereview.chromium.org/11878015/diff/2001/sdk/lib/io/path.dart#newco...
sdk/lib/io/path.dart:40: // TODO(whesse): Remove this constructor, and change
its uses to the default.
I would be in favor of just removing it as part of this changelist. I don't see
the advantage of keeping it.

https://codereview.chromium.org/11878015/diff/2001/sdk/lib/io/path.dart#newco...
sdk/lib/io/path.dart:50: * behavior may not be as expected.  Paths are
immutable.
"Paths are immutable." seems like a class comment and shouldn't be needed here?

[kustermann, 2013-01-14 17:46:16]

LGTM with one note:

I'm not 100 percent sure if we use the checked-in version of dart for
version.dart or not!

[Bill Hesse, 2013-01-14 18:23:35]

There is a problem - this is causing a failure in the Create SDK step, on
Windows.  I'm trying to track it down.

[Bill Hesse, 2013-01-14 19:34:49]

On 2013/01/14 18:23:35, Bill Hesse wrote:
> There is a problem - this is causing a failure in the Create SDK step, on
> Windows.  I'm trying to track it down.

Your note was right - this was the problem.  We are using the checked-in binary
for version.dart, and this caused the failure.

[Mads Ager (google), 2013-01-15 07:02:58]

LGTM, thanks for updating the uses Bill!