|
|
Make ui_controls only usable from interactive_ui_tests. This has two benefits:
1) don't link test code in shipping binary
2) ensure that people don't call these functions which depend on focus in sharded test targets
In a followup cl, I'll move the files to chrome\test\base
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176638
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+100 lines, -105 lines) |
Patch |
 |
M |
ash/ash.gyp
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
ash/shell.cc
|
View
|
|
3 chunks |
+0 lines, -3 lines |
0 comments
|
Download
|
|
M |
ash/shell_factory.h
|
View
|
|
2 chunks |
+0 lines, -6 lines |
0 comments
|
Download
|
|
M |
ash/ui_controls_ash.cc
|
View
|
|
7 chunks |
+14 lines, -11 lines |
0 comments
|
Download
|
|
M |
ash/wm/window_properties.h
|
View
|
|
2 chunks |
+0 lines, -8 lines |
0 comments
|
Download
|
|
M |
ash/wm/window_properties.cc
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/chrome_tests.gypi
|
View
|
|
3 chunks |
+14 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/test/base/chrome_test_launcher.cc
|
View
|
|
2 chunks |
+19 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/test/base/interactive_test_utils.cc
|
View
|
|
1 chunk |
+12 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/test/base/ui_test_utils.cc
|
View
|
|
2 chunks |
+0 lines, -14 lines |
0 comments
|
Download
|
|
M |
ui/aura/aura.gyp
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
ui/aura/test/aura_test_helper.cc
|
View
|
|
2 chunks |
+0 lines, -3 lines |
0 comments
|
Download
|
|
M |
ui/aura/ui_controls_aura.h
|
View
|
|
2 chunks |
+1 line, -4 lines |
0 comments
|
Download
|
|
M |
ui/ui.gyp
|
View
|
|
2 chunks |
+0 lines, -8 lines |
0 comments
|
Download
|
|
M |
ui/ui_controls/ui_controls.h
|
View
|
|
3 chunks |
+28 lines, -25 lines |
0 comments
|
Download
|
|
M |
ui/ui_controls/ui_controls_aura.h
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
ui/ui_controls/ui_controls_internal_win.h
|
View
|
|
2 chunks |
+11 lines, -12 lines |
0 comments
|
Download
|
|
M |
ui/views/widget/desktop_aura/desktop_root_window_host_win.cc
|
View
|
|
3 chunks |
+0 lines, -3 lines |
0 comments
|
Download
|
Total messages: 2 (0 generated)
|
Chromium Code Reviews
Issue
11878013:
Make ui_controls only usable from interactive_ui_tests. This has two benefits: (Closed)
