Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1187773008: Add FlatButton (Closed)

Created:
5 years, 6 months ago by abarth-chromium
Modified:
5 years, 6 months ago
Reviewers:
Hixie
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add FlatButton I've factored the common code for FlatButton and RaisedButton into MaterialButton. Also, tweak some of the constants in MaterialButton to better match the spec. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/531ae4f0a993cffdec57b35435ef93045da81b2c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -73 lines) Patch
M sky/sdk/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A sky/sdk/lib/widgets/flat_button.dart View 1 chunk +18 lines, -0 lines 0 comments Download
A + sky/sdk/lib/widgets/material_button.dart View 1 chunk +13 lines, -34 lines 0 comments Download
M sky/sdk/lib/widgets/raised_button.dart View 1 chunk +13 lines, -39 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 6 months ago (2015-06-16 19:04:39 UTC) #1
Hixie
lgtm
5 years, 6 months ago (2015-06-16 19:08:02 UTC) #2
abarth-chromium
5 years, 6 months ago (2015-06-16 19:19:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
531ae4f0a993cffdec57b35435ef93045da81b2c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698