Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1187773004: Add swarming support for MB (and the GN bots) in the chromium recipes. (Closed)

Created:
5 years, 6 months ago by Paweł Hajdan Jr.
Modified:
5 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, kjellander-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Add swarming support for MB (and the GN bots) in the chromium recipes. This patch adds support for swarming to bots that use the chromium recipes (chromium.py, chromium_trybot.py) and the MB build wrapper (so that we can use GN). It does this by adding a hook to the run_mb() call that takes a list of the gtest_test names (which need to match their ninja build target names) and passes that to `mb gen --swarming-targets` via a temp file. MB then re-maps the ninja target names to the GN labels, and writes a file containing the labels into the build directory, and passes that to GN (or, it will ignore this in a GYP build). Based on Dirk Pranke's CL https://codereview.chromium.org/1177593002 BUG=480053 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295711

Patch Set 1 #

Patch Set 2 : fixes #

Messages

Total messages: 6 (2 generated)
Paweł Hajdan Jr.
Patchset 1 should be same as your CL, and Patchset 2 contains my edits. What ...
5 years, 6 months ago (2015-06-16 13:51:11 UTC) #2
Dirk Pranke
lgtm. I'd prefer it if we could rename compile_specific_targets() and compile() to something like 'build_specific_targets()' ...
5 years, 6 months ago (2015-06-16 15:54:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187773004/20001
5 years, 6 months ago (2015-06-16 22:23:22 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-16 22:26:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=295711

Powered by Google App Engine
This is Rietveld 408576698