Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: Source/devtools/front_end/Runtime.js

Issue 1187743003: [DevTools] Remove remoteModules experiment, make cm_modes, screencast and emulated_devices remote f… (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/devtools/devtools.gyp ('k') | Source/devtools/front_end/inspector.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 727 matching lines...) Expand 10 before | Expand all | Expand 10 after
738 738
739 /** 739 /**
740 * @return {!Promise.<undefined>} 740 * @return {!Promise.<undefined>}
741 */ 741 */
742 _loadScripts: function() 742 _loadScripts: function()
743 { 743 {
744 if (!this._descriptor.scripts) 744 if (!this._descriptor.scripts)
745 return Promise.resolve(); 745 return Promise.resolve();
746 746
747 if (Runtime.isReleaseMode()) { 747 if (Runtime.isReleaseMode()) {
748 var useRemote = this._descriptor.remote && Runtime.experiments.isEna bled("remoteModules"); 748 var base = this._descriptor.remote && Runtime._remoteBase || undefin ed;
lushnikov 2015/06/18 14:25:26 could you please exapnd this in ternar operator? i
749 var base = useRemote && Runtime._remoteBase || undefined;
750 return loadScriptsPromise([this._name + "_module.js"], base); 749 return loadScriptsPromise([this._name + "_module.js"], base);
751 } 750 }
752 751
753 return loadScriptsPromise(this._descriptor.scripts.map(this._modularizeU RL, this)); 752 return loadScriptsPromise(this._descriptor.scripts.map(this._modularizeU RL, this));
754 }, 753 },
755 754
756 /** 755 /**
757 * @param {string} resourceName 756 * @param {string} resourceName
758 */ 757 */
759 _modularizeURL: function(resourceName) 758 _modularizeURL: function(resourceName)
(...skipping 301 matching lines...) Expand 10 before | Expand all | Expand 10 after
1061 for (var i = 0; i < params.length; ++i) { 1060 for (var i = 0; i < params.length; ++i) {
1062 var pair = params[i].split("="); 1061 var pair = params[i].split("=");
1063 var name = pair.shift(); 1062 var name = pair.shift();
1064 Runtime._queryParamsObject[name] = pair.join("="); 1063 Runtime._queryParamsObject[name] = pair.join("=");
1065 } 1064 }
1066 })();} 1065 })();}
1067 1066
1068 1067
1069 // This must be constructed after the query parameters have been parsed. 1068 // This must be constructed after the query parameters have been parsed.
1070 Runtime.experiments = new Runtime.ExperimentsSupport(); 1069 Runtime.experiments = new Runtime.ExperimentsSupport();
1071 Runtime.experiments.register("remoteModules", "Remote Modules", true);
1072 1070
1073 /** 1071 /**
1074 * @type {?string} 1072 * @type {?string}
1075 */ 1073 */
1076 Runtime._remoteBase = Runtime.queryParam("remoteBase"); 1074 Runtime._remoteBase = Runtime.queryParam("remoteBase");
1077 1075
1078 /** @type {!Runtime} */ 1076 /** @type {!Runtime} */
1079 var runtime; 1077 var runtime;
OLDNEW
« no previous file with comments | « Source/devtools/devtools.gyp ('k') | Source/devtools/front_end/inspector.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698