Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(51)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1187743003: [DevTools] Remove remoteModules experiment, make cm_modes, screencast and emulated_devices remote f… (Closed)

Created:
4 years, 10 months ago by dgozman
Modified:
4 years, 10 months ago
Reviewers:
lushnikov, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[DevTools] Remove remoteModules experiment, make cm_modes, screencast and emulated_devices remote for real. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197812

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -29 lines) Patch
M Source/devtools/BUILD.gn View 3 chunks +0 lines, -4 lines 0 comments Download
M Source/devtools/devtools.gyp View 3 chunks +0 lines, -4 lines 0 comments Download
M Source/devtools/front_end/Runtime.js View 2 chunks +1 line, -3 lines 1 comment Download
M Source/devtools/front_end/inspector.json View 1 chunk +18 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
dgozman
Take a look please.
4 years, 10 months ago (2015-06-18 13:40:48 UTC) #2
lushnikov
lgtm let's hold off committing this until branch? https://codereview.chromium.org/1187743003/diff/1/Source/devtools/front_end/Runtime.js File Source/devtools/front_end/Runtime.js (right): https://codereview.chromium.org/1187743003/diff/1/Source/devtools/front_end/Runtime.js#newcode748 Source/devtools/front_end/Runtime.js:748: var ...
4 years, 10 months ago (2015-06-18 14:25:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187743003/1
4 years, 10 months ago (2015-06-25 09:29:28 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2015-06-25 11:27:48 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197812

Powered by Google App Engine
This is Rietveld 408576698