Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart

Issue 11877029: Correctly boolify feature test. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Quotation marks Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart
diff --git a/dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart b/dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart
index e685aa66c4172e16decf37a1833872fa71155507..3d52b82fc998010ff6678445561b9e25c7a1d82e 100644
--- a/dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart
+++ b/dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart
@@ -3072,14 +3072,14 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {
FunctionSignature handleForeignRawFunctionRef(Send node, String name) {
if (node.arguments.isEmpty || !node.arguments.tail.isEmpty) {
- compiler.cancel('$name requires exactly one argument',
+ compiler.cancel('"$name" requires exactly one argument',
node: node.argumentsNode);
}
Node closure = node.arguments.head;
Element element = elements[closure];
if (!Elements.isStaticOrTopLevelFunction(element)) {
compiler.cancel(
- '$name requires a static or top-level method',
+ '"$name" requires a static or top-level method',
node: closure);
}
FunctionElement function = element;
@@ -3090,7 +3090,7 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {
FunctionSignature params = implementation.computeSignature(compiler);
if (params.optionalParameterCount != 0) {
compiler.cancel(
- '$name does not handle closure with optional parameters',
+ '"$name" does not handle closure with optional parameters',
node: closure);
}
visit(closure);
« no previous file with comments | « dart/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698