src/objects.cc - Issue 11877027: Add some runtime checks to MayNamedAccess

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 11877027: Add some runtime checks to MayNamedAccess (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index 2f2bd643484eec81d25a54b241841dfb0d4bdb25..b77163617e5ec4e3b5a4055b37bc6866cf0d5d2b 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -627,6 +627,8 @@ MaybeObject* Object::GetProperty(Object* receiver,

// that even though we may not actually end up loading the named

// property from the current object, we still check that we have

// access to it.

+ // TODO(dcarney): revert.

+ CHECK(current->IsJSObject());

JSObject* checked = JSObject::cast(current);

if (!heap->isolate()->MayNamedAccess(checked, name, v8::ACCESS_GET)) {

return checked->GetPropertyWithFailedAccessCheck(receiver,

« no previous file with comments | « src/isolate.cc ('k') | no next file » | no next file with comments »