Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 11877020: The Chrome-side of changes to use MSung* fonts as Chinese serif fonts. (Closed)

Created:
7 years, 11 months ago by jungshik at Google
Modified:
7 years, 6 months ago
CC:
chromium-reviews, hshi1, finnur+watch_chromium.org, jshin+watch_chromium.org
Visibility:
Public.

Description

The Chrome-side of changes to use MSung* fonts as Chinese serif fonts. - Change the preference values - Add new font mapping entries to Skia The ChromeOS changes will be made of 2 CLs, one adding the fonts (private repository) and the other reconfiguring fontconfig (local.conf). https://gerrit-int.chromium.org/#/c/31425/ https://gerrit.chromium.org/gerrit/#/c/41684/ BUG=chromium:158815 TEST=See bug. When all three CLs are landed, go to udn.com.tw and see if the main text looks better than before. TBR=thakis

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -5 lines) Patch
M chrome/app/resources/locale_settings_google_chromeos.grd View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/app/resources/platform_locale_settings/locale_settings_cros_zh-CN.xtb View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/app/resources/platform_locale_settings/locale_settings_cros_zh-TW.xtb View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/SkFontHost_fontconfig_direct.cpp View 1 2 3 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
jungshik at Google
7 years, 11 months ago (2013-01-19 09:19:54 UTC) #1
Daniel Erat
lgtm
7 years, 11 months ago (2013-01-19 15:08:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jshin@chromium.org/11877020/8001
7 years, 11 months ago (2013-01-25 06:46:52 UTC) #3
commit-bot: I haz the power
Presubmit check for 11877020-8001 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 11 months ago (2013-01-25 06:46:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jshin@chromium.org/11877020/8001
7 years, 11 months ago (2013-01-25 06:54:50 UTC) #5
jungshik at Google
TBR'ing with thakis because the change is trivial and similar changes have been approved by ...
7 years, 11 months ago (2013-01-25 06:56:48 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, cacheinvalidation_unittests, check_deps, chrome_frame_net_tests, chrome_frame_unittests, ...
7 years, 11 months ago (2013-01-25 07:12:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jshin@chromium.org/11877020/8001
7 years, 11 months ago (2013-01-25 08:47:19 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, cacheinvalidation_unittests, check_deps, chrome_frame_net_tests, chrome_frame_unittests, ...
7 years, 11 months ago (2013-01-25 09:07:14 UTC) #9
Nico
lgtm stamp
7 years, 11 months ago (2013-01-25 16:48:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jshin@chromium.org/11877020/8001
7 years, 11 months ago (2013-01-25 18:10:49 UTC) #11
commit-bot: I haz the power
7 years, 11 months ago (2013-01-25 18:34:40 UTC) #12
Retried try job too often on win_rel for step(s) base_unittests, browser_tests,
cacheinvalidation_unittests, check_deps, chrome_frame_net_tests,
chrome_frame_unittests, chromedriver2_unittests, components_unittests,
content_browsertests, content_unittests, crypto_unittests, gpu_unittests,
installer_util_unittests, interactive_ui_tests, ipc_tests, jingle_unittests,
media_unittests, mini_installer_test, nacl_integration, net_unittests,
ppapi_unittests, printing_unittests, remoting_unittests, sql_unittests,
sync_integration_tests, sync_unit_tests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698