Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: LayoutTests/http/tests/fetch/script-tests/request.js

Issue 1187653003: [Fetch] Check / Set .bodyUsed in Request construction if the src body is null. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/modules/fetch/Request.cpp » ('j') | Source/modules/fetch/Request.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/http/tests/fetch/script-tests/request.js
diff --git a/LayoutTests/http/tests/fetch/script-tests/request.js b/LayoutTests/http/tests/fetch/script-tests/request.js
index 44ef797bf80e9f255a731fae91c734315fbbf0ce..f0aacb885a4837b6fcb75a356d5a414055e14331 100644
--- a/LayoutTests/http/tests/fetch/script-tests/request.js
+++ b/LayoutTests/http/tests/fetch/script-tests/request.js
@@ -272,9 +272,10 @@ test(function() {
assert_false(req.bodyUsed,
'Request should not be flagged as used if it has not been ' +
'consumed.');
+ // See https://crbug.com/501195.
var req2 = new Request(req);
- assert_false(req.bodyUsed,
- 'Request should not be flagged as used if it does not have' +
+ assert_true(req.bodyUsed,
+ 'Request should be flagged as used if it does not have' +
'body.');
assert_false(req2.bodyUsed,
'Request should not be flagged as used if it has not been ' +
@@ -292,11 +293,11 @@ test(function() {
assert_false(req2.bodyUsed,
'Request should not be flagged as used if it has not been ' +
'consumed.');
- // Now we can create a Request from |req|, because creating |req2| from
- // |req| sets |req|'s body to null as specified.
- var req3 = new Request(req);
- assert_true(req.bodyUsed,
- 'Request should be flagged as used if it has been consumed.');
+ // See https://crbug.com/501195.
+ assert_throws(
+ {name: 'TypeError'},
+ function() { new Request(req); },
+ 'Request construction should throw if used.');
}, 'Request construction without body behavior regardning "bodyUsed"');
test(function() {
« no previous file with comments | « no previous file | Source/modules/fetch/Request.cpp » ('j') | Source/modules/fetch/Request.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698