Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 1187653003: [Fetch] Check / Set .bodyUsed in Request construction if the src body is null. (Closed)

Created:
5 years, 6 months ago by yhirano
Modified:
5 years, 6 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[Fetch] Check / Set .bodyUsed in Request construction if the src body is null. We need to check / set .bodyUsed in RequestConstruction when a Request is given, even if the Request has a null body. See [1] for details. 1: https://github.com/whatwg/fetch/issues/61 BUG=501195 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197325

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -8 lines) Patch
M LayoutTests/http/tests/fetch/script-tests/request.js View 2 chunks +8 lines, -7 lines 0 comments Download
M Source/modules/fetch/Request.cpp View 2 chunks +12 lines, -1 line 2 comments Download

Messages

Total messages: 7 (2 generated)
yhirano
PTAL
5 years, 6 months ago (2015-06-17 09:11:35 UTC) #2
tyoshino (SeeGerritForStatus)
lgtm https://codereview.chromium.org/1187653003/diff/1/Source/modules/fetch/Request.cpp File Source/modules/fetch/Request.cpp (right): https://codereview.chromium.org/1187653003/diff/1/Source/modules/fetch/Request.cpp#newcode55 Source/modules/fetch/Request.cpp:55: if (inputRequest->bodyUsed()) { are these if-s separated intentionally?
5 years, 6 months ago (2015-06-18 06:34:35 UTC) #3
yhirano
https://codereview.chromium.org/1187653003/diff/1/Source/modules/fetch/Request.cpp File Source/modules/fetch/Request.cpp (right): https://codereview.chromium.org/1187653003/diff/1/Source/modules/fetch/Request.cpp#newcode55 Source/modules/fetch/Request.cpp:55: if (inputRequest->bodyUsed()) { On 2015/06/18 06:34:34, tyoshino wrote: > ...
5 years, 6 months ago (2015-06-18 06:44:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187653003/1
5 years, 6 months ago (2015-06-18 07:33:13 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-18 07:37:53 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197325

Powered by Google App Engine
This is Rietveld 408576698