Issue 1187643002: VisualBench on windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1187643002: VisualBench on windows (Closed)

Created:
5 years, 6 months ago by bsalomon

Modified:
5 years, 6 months ago

Reviewers:
joshualitt

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

There are still things to sort out but this seems to run correctly. Committed: https://skia.googlesource.com/skia/+/1e7951ffdb28e2991930cc47b4c99b2c17c19196

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+207 lines, -59 lines)			Patch
M	include/views/SkOSWindow_Win.h	View	1 2 3 4	5 chunks	+42 lines, -5 lines	0 comments	Download
M	src/views/win/SkOSWindow_win.cpp	View	1 2 3 4	8 chunks	+130 lines, -15 lines	0 comments	Download
M	src/views/win/skia_win.cpp	View	1 2 3	7 chunks	+34 lines, -38 lines	0 comments	Download
M	tools/VisualBench.cpp	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (2 generated)

joshualitt

On 2015/06/15 20:36:10, bsalomon wrote: Suddenly X11 is looking pretty good... LGTM

5 years, 6 months ago (2015-06-16 13:58:40 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187643002/80001

5 years, 6 months ago (2015-06-16 13:59:09 UTC) #5

commit-bot: I haz the power

5 years, 6 months ago (2015-06-16 14:04:47 UTC) #6

Message was sent while issue was closed.

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/1e7951ffdb28e2991930cc47b4c99b2c17c19196