content/browser/service_worker/service_worker_register_job.cc - Issue 1187623006: Service Worker: Update stale workers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_register_job.cc

Issue 1187623006: Service Worker: Update stale workers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix DCHECK Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/service_worker/service_worker_register_job.cc

diff --git a/content/browser/service_worker/service_worker_register_job.cc b/content/browser/service_worker/service_worker_register_job.cc

index c4f7754fcfa406894a88ec85700517c043a6b773..28f8bc10dfaa5612b1ab744de4fcecc23b83855b 100644

--- a/content/browser/service_worker/service_worker_register_job.cc

+++ b/content/browser/service_worker/service_worker_register_job.cc

@@ -541,7 +541,8 @@ void ServiceWorkerRegisterJob::OnCompareScriptResourcesComplete(

// Only bump the last check time when we've bypassed the browser cache.

base::TimeDelta time_since_last_check =

base::Time::Now() - registration()->last_update_check();

- if (time_since_last_check > base::TimeDelta::FromHours(24) ||

+ if (time_since_last_check > base::TimeDelta::FromHours(

+ kServiceWorkerScriptMaxCacheAgeInHours) ||

new_version()->force_bypass_cache_for_scripts()) {

registration()->set_last_update_check(base::Time::Now());

context_->storage()->UpdateLastUpdateCheckTime(registration());