[Search] Store and recall search terms using NavigationEntry to improve search term extraction

content/public/browser/navigation_entry.h

Index: content/public/browser/navigation_entry.h
diff --git a/content/public/browser/navigation_entry.h b/content/public/browser/navigation_entry.h
index cc25a254cf08c2904dc5aa10e5b09122a70f481f..8765101d6e66378621730dc7662ba05fef7dd4f6 100644
--- a/content/public/browser/navigation_entry.h
+++ b/content/public/browser/navigation_entry.h
@@ -188,6 +188,10 @@ class NavigationEntry {
   // is currently only used in tests.
   virtual void SetFrameToNavigate(const std::string& frame_name) = 0;
   virtual const std::string& GetFrameToNavigate() const = 0;
+
+  // Set extra data on this NavigationEntry.
+  virtual void SetExtraData(const std::string& key, const string16& data) = 0;
+  virtual bool GetExtraData(const std::string& key, string16* data) const = 0;

[sky, 2013/01/30 23:32:03]

Document return value. Also, how does one clear a key?

[Mathieu, 2013/01/31 14:45:32]

Done. I would say clearing is the responsibility of the caller. In this case,
search_terms gets clear()'ed in the Session service and is persisted that way.

[sky, 2013/01/31 17:08:22]

There is no clear, only SetExtraData(key, ""), which is not the same as
clearing. That's my point. How does one clear a value?

 };
 
 }  // namespace content