[MIPS] Add thread-pointer to data addressing register list.

src/trusted/validator_mips/ncval.cc

 /*
  * Copyright (c) 2012 The Native Client Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include <stdio.h>
 #include <errno.h>
 #include <string.h>
 
 #include <string>
 #include <vector>
 #include <algorithm>
 
 #include "native_client/src/include/nacl_string.h"
 #include "native_client/src/trusted/validator/ncfileutil.h"
 #include "native_client/src/trusted/validator_mips/model.h"
 #include "native_client/src/trusted/validator_mips/validator.h"
 
 using nacl_mips_val::SfiValidator;
 using nacl_mips_val::CodeSegment;
 using nacl_mips_dec::RegisterList;
-using nacl_mips_dec::kRegisterStack;
 
 using std::string;
 using std::vector;
 
 /*
  * Reports problems in an easily-parsed textual format, for consumption by a
  * validation-reporting script.
  *
  * The format is as follows:
  *   ncval: <hex vaddr> <decimal safety> <problem ID string> <hex ref vaddr>
@@ skipping 15 matching lines @@
     // Collect *all* problems before returning!
     return true;
   }
 };
 
 const uint32_t kOneGig = 1U * 1024 * 1024 * 1024;
 const uint32_t kQuarterGig = 256U * 1024 * 1024;
 
 int Validate(const ncfile *ncf, bool use_zero_masks) {
   SfiValidator validator(
-      16,                                // Bytes per bundle.
-      kQuarterGig,                       // Code region size.
-      kOneGig,                           // Data region size.
-      nacl_mips_dec::kRegListReserved,   // Read only registers.
-      RegisterList(kRegisterStack));     // Data addressing register ($sp).
+      16,                             // Bytes per bundle.
+      kQuarterGig,                    // Code region size.
+      kOneGig,                        // Data region size.
+      RegisterList::ReservedRegs(),   // Read only registers.
+      RegisterList::DataAddrRegs());  // Data addressing register ($sp).

[Mark Seaborn, 2013/01/29 16:24:48]

Comment "$sp" is misleading now.  It should be "// Data addressing registers."

 
   if (use_zero_masks) {
     validator.ChangeMasks(0, 0);
   }
 
   CommandLineProblemSink sink;
 
   Elf_Shdr *shdr = ncf->sheaders;
 
   vector<CodeSegment> segments;
@@ skipping 40 matching lines @@
   ncfile *ncf = nc_loadfile(filename);
   if (!ncf) {
     fprintf(stderr, "Unable to load %s: %s\n", filename, strerror(errno));
     return 1;
   }
 
   int exit_code = Validate(ncf, use_zero_masks);
   nc_freefile(ncf);
   return exit_code;
 }