Alternate NTP: Don't hide bookmark bar on instant

chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
index e5e3387b9dea568d9fab7dda56846b8830786374..8d89ca10119dcbf5c5b87dcc2b39a8806e56e332 100644
--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
@@ -257,10 +257,7 @@ void RecordAppLaunch(Profile* profile, GURL url) {
         rb.GetNativeImageNamed(IDR_DEFAULT_FAVICON).CopyNSImage());
 
     innerContentAnimationsEnabled_ = YES;
-    // Disable state animations (for example, showing or hiding the bookmark
-    // bar) if the detached bookmark bar will be shown at the bottom of the new
-    // tab page.
-    stateAnimationsEnabled_ = ![self shouldShowAtBottomWhenDetached];
+    stateAnimationsEnabled_ = YES;
 
     // Register for theme changes, bookmark button pulsing, ...
     NSNotificationCenter* defaultCenter = [NSNotificationCenter defaultCenter];
@@ -2359,7 +2356,7 @@ static BOOL ValueInRangeInclusive(CGFloat low, CGFloat value, CGFloat high) {
 }
 
 - (BOOL)shouldShowAtBottomWhenDetached {

[dhollowa, 2013/01/18 00:55:11]

When should this method be removed?

[sail, 2013/01/18 01:37:09]

I didn't know we were removing it. If you want me to remove it, can I do it in a
separate CL?

[dhollowa, 2013/01/18 15:59:58]

Kuan has done some removal already, best to coordinate with her.

[kuan, 2013/01/18 16:09:29]

i only removed all bottom bmb in win/cros code in r177659
(https://chromiumcodereview.appspot.com/12013004/); i didn't touch mac code.

[sail, 2013/01/18 16:28:51]

Sounds like it's ok to do this in a separate CL. Thanks.

-  return chrome::search::IsInstantExtendedAPIEnabled(browser_->profile());
+  return NO;
 }
 
 #pragma mark BookmarkButtonDelegate Protocol