Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(11)

Issue 11876026: Merge 139509 (Closed)

Created:
7 years, 9 months ago by James Simonsen
Modified:
7 years, 9 months ago
Reviewers:
James Simonsen
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1364/
Visibility:
Public.

Description

Merge 139509 > Restore old semantics to webkitRequestAnimationFrame callbacks > https://bugs.webkit.org/show_bug.cgi?id=106697 > > Reviewed by James Robinson. > > Source/WebCore: > > Sites that use GWT <= 2.4 are buggy and rely on Date.now()-like callback values. > We'll restore that behavior to the prefixed version of webkitRequestAnimationFrame. > requestAnimationFrame will continue to follow the spec. > > Test: fast/animation/request-animation-frame-prefix.html > > * dom/RequestAnimationFrameCallback.h: > (RequestAnimationFrameCallback): > * dom/ScriptedAnimationController.cpp: > (WebCore::ScriptedAnimationController::serviceScriptedAnimations): > * page/DOMWindow.cpp: > (WebCore::DOMWindow::requestAnimationFrame): > (WebCore): > (WebCore::DOMWindow::webkitRequestAnimationFrame): > * page/DOMWindow.h: > (DOMWindow): > * page/DOMWindow.idl: > > LayoutTests: > > * fast/animation/request-animation-frame-prefix-expected.txt: Added. > * fast/animation/request-animation-frame-prefix.html: Added. > * fast/animation/script-tests/request-animation-frame-prefix.js: Added. > (busyWait): > (window.webkitRequestAnimationFrame): > TBR=simonjam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139635

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, --1 lines) Patch
A + LayoutTests/fast/animation/request-animation-frame-prefix.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/animation/request-animation-frame-prefix-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/animation/script-tests/request-animation-frame-prefix.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/dom/RequestAnimationFrameCallback.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/dom/ScriptedAnimationController.cpp View 2 chunks +5 lines, -1 line 0 comments Download
M Source/WebCore/page/DOMWindow.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/page/DOMWindow.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/WebCore/page/DOMWindow.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
James Simonsen
7 years, 9 months ago (2013-01-14 19:43:53 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698